Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/1.28 - Official dark mode support for macOS Mojave #60790

Closed
wants to merge 23 commits into from
Closed

Release/1.28 - Official dark mode support for macOS Mojave #60790

wants to merge 23 commits into from

Commits on Oct 1, 2018

  1. use hosted build agents for linux builds

    @joaomoreno
    joaomoreno committed Oct 1, 2018
    Copy the full SHA
    3997d29 View commit details
    Browse the repository at this point in the history

  2. compare fsPaths instead of a fsPath and a path

    @jrieken
    jrieken committed Oct 1, 2018
    Copy the full SHA
    5f642c0 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #59727 from Microsoft/use-linux-hosted-build-agents 

    Use hosted build agents for Linux builds
    @joaomoreno
    joaomoreno committed Oct 1, 2018
    Copy the full SHA
    4cb735f View commit details
    Browse the repository at this point in the history

  4. linux build: limit yarn child concurrency

    @joaomoreno
    joaomoreno committed Oct 1, 2018
    Copy the full SHA
    9d8bcd4 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #59738 from Microsoft/linux-limit-yarn-child-concu… 

    …rrency

linux build: limit yarn child concurrency
    @joaomoreno
    joaomoreno committed Oct 1, 2018
    Copy the full SHA
    83d5a29 View commit details
    Browse the repository at this point in the history

  6. Remove built-in toml basic language support (#59775) 

    Reverts #59089

After further discussions with the team, we decided that we should not ship a bundled toml grammar. There are two reasons for this:

* For the best toml experiance, users should use one of the toml plugins from the marketplace as these provide intellisense and other advanced language features. We previously recommend these plugins when you opened a toml file. However if we ship a bundled toml grammar, these recommendations will no longer appear

* Engineering maintance costs on our side. Updating the grammar, maintaining tests, and handling issues related to it are all extra work that has to be considered.

For these reasons, we do not think it makes sense to include basic toml support
    @mjbvz
    mjbvz committed Oct 1, 2018
    Copy the full SHA
    99b5434 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2018

  1. debug: restart shuold also resolve configuration by providers when it… 

    … changed

fixes #59795
    @isidorn
    isidorn committed Oct 2, 2018
    Copy the full SHA
    ccd11a3 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #59819 from Microsoft/isidorn/debugRestartResolve 

    debug: restart shuold also resolve configuration by providers when changed
    @isidorn
    isidorn committed Oct 2, 2018
    Copy the full SHA
    60db21f View commit details
    Browse the repository at this point in the history

  3. Don't force update webview content when retainContextWhenHidden is se… 

    …t and contents have not changed (#59842)

Fixes #59823
    @mjbvz
    mjbvz committed Oct 2, 2018
    Copy the full SHA
    2d676e6 View commit details
    Browse the repository at this point in the history

  4. Track experiment id (#59856)

    @ramya-rao-a @mjbvz
    ramya-rao-a authored and mjbvz committed Oct 2, 2018
    Copy the full SHA
    85d970a View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2018

  1. only have the n second timeout for prelaunch tasks that do not send a… 

    …n active event

fixes #59835
    @isidorn
    isidorn committed Oct 3, 2018
    Copy the full SHA
    8bd5a47 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #59889 from Microsoft/isidorn/prelaunchTask 

    only have the n second timeout for prelaunch tasks that do not send active
    @isidorn
    isidorn committed Oct 3, 2018
    Copy the full SHA
    431ef9d View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2018

  1. debug: send out name with setVariable request 

    fixes #60444
    @isidorn
    isidorn committed Oct 10, 2018
    Copy the full SHA
    b331f6b View commit details
    Browse the repository at this point in the history

  2. Fixes #59328

    @alexdima
    alexdima committed Oct 10, 2018
    Copy the full SHA
    86671f0 View commit details
    Browse the repository at this point in the history

  3. Fixes #60318

    @alexdima
    alexdima committed Oct 10, 2018
    Copy the full SHA
    7d97112 View commit details
    Browse the repository at this point in the history

  4. Apply selection even when the items don't change 

    Fixes #59876
    @Tyriar
    Tyriar committed Oct 10, 2018
    Copy the full SHA
    83106c5 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #60545 from Microsoft/tyriar/1.28/59876 

    Apply selection even when the items don't change
    @Tyriar
    Tyriar committed Oct 10, 2018
    Copy the full SHA
    3f23ae9 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2018

  1. bump build version

    @kieferrm
    kieferrm committed Oct 11, 2018
    Copy the full SHA
    3368db6 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2018

  1. Revert "removeFromRecentlyOpened Command Broken. Fixes #58131" 

    This reverts commit 0c0d368.
    @chrmarti
    chrmarti committed Oct 12, 2018
    Copy the full SHA
    e7da892 View commit details
    Browse the repository at this point in the history

  2. Revert to previous check (fixes #60243)

    @chrmarti
    chrmarti committed Oct 12, 2018
    Copy the full SHA
    e66c334 View commit details
    Browse the repository at this point in the history

  3. debug: on restart, make sure to first disconnect and only then run th… 

    …e prelaunch tasks

fixes #60593
    @isidorn
    isidorn committed Oct 12, 2018
    Copy the full SHA
    7fe1760 View commit details
    Browse the repository at this point in the history

  4. thenable -> tpromise

    @isidorn
    isidorn committed Oct 12, 2018
    Copy the full SHA
    305ea62 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #60787 from Microsoft/isidorn/restartOrder 

    debug: on restart, make sure to first disconnect and only then run th…
    @isidorn
    isidorn committed Oct 12, 2018
    Copy the full SHA
    42a5edf View commit details
    Browse the repository at this point in the history