Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin tabs similar to Visual Studio #26965

Closed
wants to merge 3 commits into from
Closed

Conversation

teintinu
Copy link
Contributor

@teintinu teintinu commented May 19, 2017

  • IEditorInput.pinned from boolean to export enum Pinned {NO, SOFT, HARD} . NO = preview, SOFT is the current vscode pinned, and HARD is pin similar to Visual Studio
  • CloseAllButPinned action and methods that close all editor where pinned !== HARD
  • DblClick in title pin hard
  • replaced CloseAllEditors by CloseAllButPinned in hotkey and explorerviewlet
  • TODO:
    • Fix the terminology to clarify and one just one term for each concept
      • NO/PREVIEW
      • SOFT/KEEPOPEN
      • HARD/PINNED
    • Unpin
    • better UI
    • remember pinned tabs on vscode restart
    • more tests (just one test with HARD pin included)

I suggest new PRs for TODO's to avoid mergeconflicts

refers to #12622

@mention-bot
Copy link

@thr0w, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bpasero and @egamma to be potential reviewers.

@msftclas
Copy link

@thr0w,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@bpasero
Copy link
Member

bpasero commented Aug 11, 2017

Closing due to inactivity.

@bpasero bpasero closed this Aug 11, 2017
@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants