Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render block by default on minimap #21452

Closed
wants to merge 1 commit into from
Closed

Render block by default on minimap #21452

wants to merge 1 commit into from

Conversation

octref
Copy link
Contributor

@octref octref commented Feb 26, 2017

@mention-bot
Copy link

@octref, thanks for your PR! By analyzing the history of the files in this pull request, we identified @alexandrudima and @egamma to be potential reviewers.

@alexdima
Copy link
Member

alexdima commented Mar 6, 2017

@octref I think this is a matter of taste, where there is no clear right or wrong, or there is no superior or inferior option.

IMHO rendering characters is a good default, it is what both Sublime and Visual Studio do out of the box. Atom renders blocks out of the box, as they cannot render characters.

We have the option to turn rendering into blocks and I think people will choose what they like most. I personally switch the toggle on/off as I am going from high-DPI display to low-DPI display.

@alexdima alexdima closed this Mar 6, 2017
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants