cli: fix tunnels not working on Windows #211499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I made a change this past iteration to use `CREATE_BREAKAWAY_FROM_JOB` in order to allow the code-server process to outlive SSH connections run from the exec server. However, it appears that this _can_ break things if it's run from a job that doesn't have the JOB_OBJECT_LIMIT_BREAKAWAY_OK flag set. I'm not a winapi expert, so this is a simple though perhaps inefficient change to probe whether we can do this via an echo command before starting the server.
connor4312
added
the
candidate
lramos15
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a change this past iteration to use
CREATE_BREAKAWAY_FROM_JOBin order to allow the code-server process to outlive SSH connections run
from the exec server.
However, it appears that this can break things if it's run from a job
that doesn't have the JOB_OBJECT_LIMIT_BREAKAWAY_OK flag set. I'm not
a winapi expert, so this is a simple though perhaps inefficient change
to probe whether we can do this via an echo command before starting the
server.