Ensure titlebar is at least as tall as the bounding rect of WCO #211440
+12
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #171415
For browsers where the Window Control Overlay is taller than 35px (for example Chrome on a Mac), there is a disjoint between the 35px tall titlebar and the OS provided titlebar.
To avoid this, we should ensure that if WCO is enabled, the titlebar div height is at least the height of the bounding rectangle.
Confirmation required: should we set the min value to
getWCOBoundingRect()?.heightbefore or after we apply the zoom factor?