refactor: support dynamic terminal prompt detection without regex on windows #211382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chapman Pendery <cpendery@microsoft.com>
Tyriar
requested changes
Apr 26, 2024
src/vs/workbench/contrib/terminal/browser/media/shellIntegration-bash.sh
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminal/browser/media/shellIntegration-bash.sh
Outdated
Show resolved
Hide resolved
Signed-off-by: Chapman Pendery <cpendery@microsoft.com>
Tyriar
approved these changes
May 1, 2024
rzhao271
approved these changes
May 1, 2024
|
I'm seeing this on my mac: 
bash version too old? |
@Tyriar the |
|
I added a simple v4+ check to fix it quick |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #210776 (comment) & similar to #209136, this PR adds support for detecting terminal prompts that fall outside the existing regexes. Prompt detection should be able to handle most new prompts once this & #211222 are closed.
Testing
Before (git-bash)
beforeDynamicPrompt.mp4
After (git-bash)
afterDynamicPrompt.mp4
Git Bash
Pwsh