Introduce PromptInputModel that gives a more reliable and testable view of the current command line #210615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
changed the title
jrieken
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the new
PromptInputModelclass which has a more reliable and testable view of the current command line when shell integration is available. This adds reporting of the line continuation from pwsh and bash to improve these results.This also removed the text area overlay feature in dev mode and replaced it with a status bar item that reflects the current prompt using
|for the cursor and⏎for a new line:Follow ups:
fyi @cpendery I plan on adopting this in the suggest widget which should make a lot of things easier 👍