Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark .ember-cli as jsonc instead of json #110541

Merged
merged 1 commit into from Nov 13, 2020
Merged

Conversation

loganrosen
Copy link
Member

The .ember-cli file generated by Ember is JSON with Comments (jsonc): https://github.com/ember-cli/ember-cli/blob/master/blueprints/app/files/.ember-cli

I've changed its associated language accordingly because it being the JSON type by default causes red underlines in the generated file.

This PR fixes #110540

The .ember-cli file generated by Ember is JSON with Comments (jsonc): https://github.com/ember-cli/ember-cli/blob/master/blueprints/app/files/.ember-cli

I've changed its associated language accordingly because it being the JSON type by default causes red underlines in the generated file.
@aeschli aeschli added this to the November 2020 milestone Nov 13, 2020
@aeschli aeschli added the languages-basic Basic language support issues label Nov 13, 2020
@aeschli aeschli merged commit c5ee747 into microsoft:master Nov 13, 2020
@aeschli
Copy link
Contributor

aeschli commented Nov 13, 2020

Thanks @loganrosen !

@loganrosen loganrosen deleted the ember-cli branch November 13, 2020 22:02
@github-actions github-actions bot locked and limited conversation to collaborators Dec 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
languages-basic Basic language support issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.ember-cli has incorrect language association
2 participants