Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display command name in the status bar after a keybinding #85790

Closed
amgalan81mn opened this issue Nov 29, 2019 · 10 comments
Closed

Display command name in the status bar after a keybinding #85790

amgalan81mn opened this issue Nov 29, 2019 · 10 comments
Labels
feature-request Request for new features or functionality info-needed Issue requires more information from poster keybindings VS Code keybinding issues *out-of-scope Posted issue is not in scope of VS Code

Comments

@amgalan81mn
Copy link

when pressed second key then display command name for short time
ctrl+k was pressed, waiting for second key of chord... "code folding -> collapsed to level 2"

@vscodebot
Copy link

vscodebot bot commented Nov 29, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@gjsjohnmurray
Copy link
Contributor

Please clarify. Are you reporting a bug? Or requesting an enhancement?

@sandy081
Copy link
Member

sandy081 commented Dec 1, 2019

Why is it only for chord keys but also for all keys?

@sandy081 sandy081 added the info-needed Issue requires more information from poster label Dec 1, 2019
@amgalan81mn
Copy link
Author

amgalan81mn commented Dec 2, 2019 via email

@alexdima alexdima changed the title command key Display command name in the status bar after a keybinding Dec 2, 2019
@alexdima alexdima added feature-request Request for new features or functionality keybindings VS Code keybinding issues and removed info-needed Issue requires more information from poster labels Dec 2, 2019
@alexdima alexdima added this to the Backlog Candidates milestone Dec 2, 2019
@alexdima alexdima removed their assignment Dec 2, 2019
@vscodebot
Copy link

vscodebot bot commented Jan 15, 2020

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@alexdima
Copy link
Member

alexdima commented Feb 4, 2020

I have tried out the changes in PR #86524, but I have to be honest and say that I personally don't find this a useful addition to VS Code, it does not feel natural to me for the status bar to constantly echo and repeat the action I executed.

Are there other editors that do what is proposed here?

@alexdima alexdima added the info-needed Issue requires more information from poster label Feb 4, 2020
@vincentfiestada
Copy link

I assume this is trying to achieve some vim-like features around keybindings? But I agree that this doesn't seem very useful.

  1. If I use a keybinding, I probably already knew what it was going to do.
  2. If not, it may have been by accident, in which case should the command stay in the status bar long enough for me to notice? What if I accidentally use 2 keybindings in a row, then this feature doesn't help me at all. And wouldn't most users simply notice the accidental change and undo?
  3. This doesn't help with feature discovery, unlike the command palette.

At the very best, this seems out-of-scope and should be implemented by an extension instead.

@gjsjohnmurray
Copy link
Contributor

I concur with @alexdima and @vincentfiestada

If the goal is to answer the question, "hey, what did I just do there?" perhaps add a new OutputChannel, logging each command that gets executed. Then the interested user can view this in the Output tab of the Panel.

@alexdima
Copy link
Member

alexdima commented Feb 5, 2020

If the goal is to answer the question, "hey, what did I just do there?" perhaps add a new OutputChannel, logging each command that gets executed. Then the interested user can view this in the Output tab of the Panel.

This already happens. When using the trace log level, each executed command is logged.

I have also presented this issue in today's standup and there was unanimous agreement that we don't want this feature, so I will close this issue for now as "out-of-scope".

@alexdima alexdima added the *out-of-scope Posted issue is not in scope of VS Code label Feb 5, 2020
@vscodebot
Copy link

vscodebot bot commented Feb 5, 2020

We closed this issue because we don't plan to address it in the foreseeable future. You can find more detailed information about our decision-making process here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

@vscodebot vscodebot bot closed this as completed Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality info-needed Issue requires more information from poster keybindings VS Code keybinding issues *out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants