Skip to content

Commit

Permalink
Suppress semantic errors in js/ts notebook cells (#212367)
Browse files Browse the repository at this point in the history
Fixes #212366
  • Loading branch information
mjbvz committed May 9, 2024
1 parent 90dfd06 commit 268c20f
Showing 1 changed file with 6 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import { CommandManager } from './commands/commandManager';
import { DocumentSelector } from './configuration/documentSelector';
import * as fileSchemes from './configuration/fileSchemes';
import { LanguageDescription } from './configuration/languageDescription';
import { Schemes } from './configuration/schemes';
import { DiagnosticKind } from './languageFeatures/diagnostics';
import FileConfigurationManager from './languageFeatures/fileConfigurationManager';
import { TelemetryReporter } from './logging/telemetry';
Expand Down Expand Up @@ -145,6 +146,11 @@ export default class LanguageProvider extends Disposable {
return;
}

// Disable semantic errors in notebooks until we have better notebook support
if (diagnosticsKind === DiagnosticKind.Semantic && file.scheme === Schemes.notebookCell) {
return;
}

const config = vscode.workspace.getConfiguration(this.id, file);
const reportUnnecessary = config.get<boolean>('showUnused', true);
const reportDeprecated = config.get<boolean>('showDeprecated', true);
Expand Down

0 comments on commit 268c20f

Please sign in to comment.