add GHPR accessibility help #5936
Conversation
package.json
Outdated
| }, | ||
| { | ||
| "id": "issues:github", | ||
| "name": "%view.issues.github.name%", | ||
| "when": "ReposManagerStateContext != NeedsAuthentication && !github:resolvingConflicts", | ||
| "icon": "$(issues)" | ||
| "icon": "$(issues>", |
There was a problem hiding this comment.
| "icon": "$(issues>", | |
| "icon": "$(issues)", |
package.json
Outdated
| @@ -662,13 +663,15 @@ | |||
| "id": "pr:github", | |||
| "name": "%view.pr.github.name%", | |||
| "when": "ReposManagerStateContext != NeedsAuthentication && !github:resolvingConflicts", | |||
| "icon": "$(git-pull-request)" | |||
| "icon": "$(git-pull-request)", | |||
| "accessibilityHelpContent": "Helpful commands include: \n-Refresh PR List <keybinding:pr.refreshList>\n-GitHub Pull Requests: Focus on Issues View <keybinding:issue.refresh> \n-GitHub Pull Requests: Focus on Pull Requests View <keybinding:pr:github.focus>\n-GitHub Issues: Copy GitHub Permalink <keybinding:issue.copyGithubPermalink>\n-GitHub Issues: Create an Issue <keybinding:issue.createIssue>\n-GitHub Pull Requests: Create Pull Request <keybinding:command:pr.create>\n-GitHub Pull Requests: Start Review <keybinding:pr.startReview>\n-GitHub Pull Requests: Mark Pull Request Ready For Review <keybinding:pr.readyForReview>\n-GitHub Pull Requests: Approve <keybinding:review.approve>" | |||
There was a problem hiding this comment.
These should both be localized.
There was a problem hiding this comment.
Also, not all these commands support keybindings. The following should be removed:
- GitHub Pull Requests: Mark Pull Request Ready For Review
- GitHub Pull Requests: Start Review
- GitHub Pull Requests: Approve
There was a problem hiding this comment.
What is the syntax for these supposed to be? I see this, which isn't a valid markdown link:
[Refresh issues](command:issue.refresh><keybinding:issue.refresh>There was a problem hiding this comment.
It doesn't look like this markdown and special keybinding syntax works. Here's what I tried:
Helpful commands include:\n-[Refresh PR List](command:pr.refreshList)<keybinding:pr.refreshList>\n-[Refresh issues](command:issue.refresh)<keybinding:issue.refresh>\n-[GitHub Pull Requests: Focus on Issues View](command:issues:github.focus)<keybinding:issue.refresh> \n-[GitHub Pull Requests: Focus on Pull Requests View](command:pr:github.focus)<keybinding:pr:github.focus>\n-[GitHub Issues: Copy GitHub Permalink](command:issue.copyGithubPermalink)<keybinding:issue.copyGithubPermalink>\n-[GitHub Issues: Create an Issue](command:issue.createIssue)<keybinding:issue.createIssue>\n-[GitHub Pull Requests: Create Pull Request](command:pr.create)<keybinding:command:pr.create>\n
And here's what it looked like:
There was a problem hiding this comment.
I'll remove the markdown and keybinding syntax for now.
There was a problem hiding this comment.
that looks correct, there's an issue to improve upon this microsoft/vscode#210665
There was a problem hiding this comment.
This looks unfinished to me. Why do we show raw markdown in an end-user features?
package.json
Outdated
| @@ -29,7 +29,8 @@ | |||
| "shareProvider", | |||
| "tabInputTextMerge", | |||
| "tokenInformation", | |||
| "treeViewMarkdownMessage" | |||
| "treeViewMarkdownMessage", | |||
| "contribAccessibilityHelpContent" | |||
There was a problem hiding this comment.
GHPR doesn't yet have permission to use this proposal.
There was a problem hiding this comment.
Enabled permission and alphabetized.
fixes #5933
Once microsoft/vscode#210116 is merged shortly, we can adopt this here 馃槃 .
I am out tomorrow until Tuesday, so pls tweak and merge this.
I added most commands from the list JooYoung provided to the dialog. #5933 (comment)