Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crashpad] Update to latest version 2024-05-10 #38703

Closed
wants to merge 3 commits into from

Conversation

RealChuan
Copy link
Contributor

@RealChuan RealChuan commented May 12, 2024

Fixes #38702

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@RealChuan RealChuan changed the title [crashpad] Fix atomic_thread_fence for linux [crashpad] Update to latest version 2024-05-10 May 12, 2024
@RealChuan
Copy link
Contributor Author

@Cheney-W Cheney-W added the category:port-update The issue is with a library, which is requesting update new revision label May 13, 2024
@RealChuan RealChuan marked this pull request as ready for review May 13, 2024 10:57
@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label May 14, 2024
// Work around libstdc++ bug 51038 where atomic_thread_fence was declared but
// not defined, leading to the linker complaining about undefined references.
- __atomic_thread_fence(std::memory_order_seq_cst);
+ __atomic_thread_fence(static_cast<int>(std::memory_order_seq_cst));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an upstream patch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you submit this patch upstream?

@data-queue data-queue marked this pull request as draft May 16, 2024 19:39
@data-queue data-queue removed the info:reviewed Pull Request changes follow basic guidelines label May 16, 2024
@RealChuan RealChuan closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[crashpad] Build error on x64-linux
4 participants