Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[icu] Add reminder to install autoconf-archive #38019

Merged
merged 6 commits into from May 17, 2024

Conversation

MonicaLiu0311
Copy link
Contributor

Fixes #38005.
By user request, add a reminder to install autoconf-archive on non-windows machines.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • ·Any fixed CI baseline entries are removed from that file.~
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@MonicaLiu0311 MonicaLiu0311 added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. labels Apr 7, 2024
@MonicaLiu0311 MonicaLiu0311 marked this pull request as ready for review April 8, 2024 02:21
LilyWangLL
LilyWangLL previously approved these changes Apr 8, 2024
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Apr 8, 2024
@MonicaLiu0311
Copy link
Contributor Author

I canceled the CI Pipeline run because it only added a reminder and did not change the build process.

@MonicaLiu0311 MonicaLiu0311 changed the title [icu] Add a reminder [icu] Add reminder to install autoconf-archive Apr 8, 2024
Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disapproval.
When you need autoconf-archive, you also need additional packages.

@LilyWangLL LilyWangLL removed the info:reviewed Pull Request changes follow basic guidelines label Apr 8, 2024
@MonicaLiu0311
Copy link
Contributor Author

Disapproval. When you need autoconf-archive, you also need additional packages.

So do you think it's better to keep the current status or add other additional packages to the reminder? Or is there another plan? Looking forward to your reply.

@dg0yt
Copy link
Contributor

dg0yt commented Apr 10, 2024

So do you think it's better to keep the current status

I don't think the current status is acceptable. There is even a guideline that ports should print such hints. I wonder why it took so long to see action. It has been reported several times IIRC.

or add other additional packages to the reminder?

Yes, please. There is prior art. For example python3.

Or is there another plan?

There is no plan. However, I still think that the current way of adding these warnings is immature. The ports should just declare dependencies and delegate actions to a shared facility. But what we get is each port carrying a (different) copy of explicit instructions for installing dependencies.

@LilyWangLL LilyWangLL marked this pull request as draft April 16, 2024 06:57
@MonicaLiu0311
Copy link
Contributor Author

I canceled the CI Pipeline run because it only added a reminder and did not change the build process.

Again.

@MonicaLiu0311 MonicaLiu0311 marked this pull request as ready for review May 11, 2024 08:49
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label May 14, 2024
@data-queue
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@data-queue data-queue merged commit f8d65dc into microsoft:master May 17, 2024
17 checks passed
@MonicaLiu0311 MonicaLiu0311 deleted the Dev/Monica/fix_icu branch May 20, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[icu] build failure
4 participants