Skip to content
This repository has been archived by the owner on Jun 11, 2020. It is now read-only.

Keep local references out of testDependencies #777

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jablko
Copy link
Contributor

@jablko jablko commented Apr 30, 2020

diff --git a/data/definitions.json b/data/definitions.json
index a4ad92e..120e306 100644
--- a/data/definitions.json
+++ b/data/definitions.json
@@ -60217,9 +60217,7 @@
             ],
             "license": "MIT",
             "dependencies": [],
-            "testDependencies": [
-                "./addon.pdf"
-            ],
+            "testDependencies": [],
             "pathMappings": [
                 {
                     "packageName": "dwt",
@@ -214895,9 +214893,7 @@
             ],
             "license": "MIT",
             "dependencies": [],
-            "testDependencies": [
-                "../rangy/rangy-classapplier"
-            ],
+            "testDependencies": [],
             "pathMappings": [],
             "packageJsonDependencies": [],
             "contentHash": "d1899dc0e467a283661356bcab863f8ef5a003762dea18e8242d2ab8a60f20c7",
@@ -217965,8 +217961,7 @@
                 "react-addons-transition-group",
                 "react-addons-update",
                 "create-react-class",
-                "react-dom-factories",
-                "../experimental"
+                "react-dom-factories"
             ],
             "pathMappings": [],
             "packageJsonDependencies": [
@@ -268314,12 +268309,7 @@
                     "version": "*"
                 }
             ],
-            "testDependencies": [
-                "../../slickgrid/slick.autotooltips",
-                "../../slickgrid/slick.checkboxselectcolumn",
-                "../../slickgrid/slick.rowselectionmodel",
-                "../../slickgrid/slick.columnpicker"
-            ],
+            "testDependencies": [],
             "pathMappings": [],
             "packageJsonDependencies": [],
             "contentHash": "6cb78ad932a919d0ce2aab13e58b1af628eff8eb3583d59f6a68ad9253e25d5e",
@@ -276550,9 +276540,7 @@
             ],
             "license": "MIT",
             "dependencies": [],
-            "testDependencies": [
-                "../strophe/muc"
-            ],
+            "testDependencies": [],
             "pathMappings": [],
             "packageJsonDependencies": [],
             "contentHash": "65a8cce5c3218653d6542901ffc6dd036f1c5d9da8a4070e9037f13c6f56b56e",
@@ -276585,9 +276573,7 @@
             ],
             "license": "MIT",
             "dependencies": [],
-            "testDependencies": [
-                "../strophe.js/muc"
-            ],
+            "testDependencies": [],
             "pathMappings": [],
             "packageJsonDependencies": [],
             "contentHash": "a2fc0bf002da5df42cd95a62b2f4c1575ebd015e39540f6c86337b4271f00cdf",
@@ -298117,7 +298103,6 @@
             "license": "MIT",
             "dependencies": [],
             "testDependencies": [
-                "../waypoints/jquery",
                 "jquery"
             ],
             "pathMappings": [],
@@ -299177,9 +299162,7 @@
                     "version": "*"
                 }
             ],
-            "testDependencies": [
-                "../next"
-            ],
+            "testDependencies": [],
             "pathMappings": [],
             "packageJsonDependencies": [
                 {

Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make a test that gives an example of a package that this fixes? I don't understand what references are producing things like "./addon.pdf"

Same comment as your other PRs about moving to DefinitelyTyped-tools and adding a test.

@sandersn
Copy link
Member

sandersn commented Jun 5, 2020

I'm guessing that a package's test.ts has import x = require('./addon.pdf'), which (1) is a weird thing to write (2) should definitely be excluded from testDependencies.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants