Skip to content
This repository has been archived by the owner on Jun 11, 2020. It is now read-only.

Add dependencies for import types #767

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add dependencies for import types #767

wants to merge 1 commit into from

Conversation

jablko
Copy link
Contributor

@jablko jablko commented Apr 21, 2020

Fixes #575

@jablko jablko mentioned this pull request Apr 21, 2020
Merged
@sandersn
Copy link
Member

sandersn commented Jun 9, 2020

Fixes microsoft/DefinitelyTyped-tools#47

sandersn
sandersn suggested changes Jun 9, 2020
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; same comment as others: needs a test and port to microsoft/DefinitelyTyped-tools

src/lib/module-info.ts
}
break;
}

default:
ts.forEachChild(node, recur);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this also fix microsoft/DefinitelyTyped-tools#44? Probably not, but the additional tree walking surely makes some difference.

@jablko jablko mentioned this pull request Aug 27, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sandersn sandersn sandersn requested changes

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh RyanCavanaugh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jablko @sandersn