This repository has been archived by the owner on Jun 11, 2020. It is now read-only.
For dependent packages, only test against typescript@next #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
8 tasks
4 tasks
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally we test against both
typescript@nextand the minimum available TypeScript version. This would change it so that for dependencies, we would only test againsttypescript@next. This should help with DefinitelyTyped/DefinitelyTyped#20308.This means adding a
--onlyTestTsNextoption to dtslint: microsoft/dtslint#87.To avoid this causing problems when a package changes the TS version it depends on, this adds a new rule that if A depends on B, A must have a greater TS version than B. This is done by DefinitelyTyped/DefinitelyTyped#21288.