Upgrade TypeScript, Jest, Prettier, etc. to modern versions #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
skiptirengu
suggested changes
Aug 12, 2021
| @@ -14,7 +14,7 @@ jobs: | |||
|
|
|||
| strategy: | |||
| matrix: | |||
| node-version: [8.x, 10.x, 12.x] | |||
| node-version: [10.x, 12.x, 14.x] | |||
There was a problem hiding this comment.
If we're dropping support for older node versions, this new requirement should also be updated on the "engines" section of the package.json file.
There was a problem hiding this comment.
IMO we should probably also bump the major package version.
|
Curious what the timeframe might be for getting this merged and released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
I found that my code wouldn't compile when using modern TS syntax (e.g.
?.and??were not available). Upgrading TS required upgrading the rest of the dev environment stack.What does this PR do?
The versions of the dev dependencies were very old, so I updated them to the latest versions. I ran the linter and fixed the new issues
What testing was done?
Ran UTs.