Suggest autofixes for declaration diagnostics #30
Conversation
| @@ -112,16 +112,16 @@ export const checkOptions = async (opt: Options): Promise<[string[], string[]]> | |||
|
|
|||
| // Check git status if the write flag was provided and the output folder is the same as the project folder | |||
| // Do not allow overwriting files with previous changes on them unless --ignoreGitStatus flag was provided | |||
| if (opt.write && path.dirname(opt.tsconfig) === opt.outputFolder) { | |||
| if (!opt.ignoreGitStatus && opt.write && path.dirname(opt.tsconfig) === opt.outputFolder) { | |||
There was a problem hiding this comment.
Yeah, I noticed this one when I tried ts-fix last.
|
@microsoft-github-policy-service agree company="Airtable" |
Gotta sneak these in somehow 😉 (since typo fix PRs tend to look like spam) |
|
CI doesn't like this PR, it's probably not your fault, though. I'll look later. |
|
@MichaelMitchell-at, I tried this branch but still can't get fixes working, what am I missing? |
Have you tried running it across the individual sub-projects? I wouldn't expect ts-fix to follow references. |
Yep, that works! It might be only me but I find this confusing, and there is no warning anywhere either! Thanks anyway! |
|
Actually the CI problems are real; the tests are not actually typechecked so that's being missed. |
This is to allow autofixes for errors like microsoft/TypeScript#58260.
Test plan:
ts-fix -t <path_to_tsconfig> -e9013 -f add-annotation --write --ignoreGitStatusand verify that type annotations are automatically added where necessary.Fixes #32