L7 Irish: convert to IntersectionDataset #2034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've got this down to 210. Some files actually overlap in both time and space:
I actually have a different idea, let me try that instead. |
|
Okay, now we're back down to 206 like the original dataset. Note that the above pairs of images that overlap may be double-counted. However, this is the same behavior as we had before. |
adamjstewart
force-pushed
the
datasets/l7irish
branch
from
bcd5def
to
f9cbd0d
Compare
adamjstewart
force-pushed
the
datasets/l7irish
branch
from
f9cbd0d
to
71a3123
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts L7 Irish to an IntersectionDataset following the design proposed in #1972.
This is needed for #2015 so that images and masks can independently control their resampling algorithm.
Only remaining bug is that the length of the dataset jumped from 206 to 438, which implies that some images in the dataset overlap.Will do the same thing to L8 Biome after this is merged.
@yichiac