Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaning command line validations and adding unit tests #2842

Merged
merged 8 commits into from May 13, 2024
Merged

Cleaning command line validations and adding unit tests #2842

merged 8 commits into from May 13, 2024

Conversation

fhnaseer
Copy link
Member

  • Removed extra validations
  • Added command line arguments validation tests

nohwnd
nohwnd reviewed May 13, 2024
View reviewed changes
src/Platform/Microsoft.Testing.Platform/CommandLine/PlatformCommandLineProvider.cs Outdated Show resolved Hide resolved
src/Platform/Microsoft.Testing.Platform/CommandLine/PlatformCommandLineProvider.cs Outdated Show resolved Hide resolved
...itTests/Microsoft.Testing.Platform.UnitTests/CommandLine/PlatformCommandLineProviderTests.cs Outdated Show resolved Hide resolved
...itTests/Microsoft.Testing.Platform.UnitTests/CommandLine/PlatformCommandLineProviderTests.cs Outdated Show resolved Hide resolved
...itTests/Microsoft.Testing.Platform.UnitTests/CommandLine/PlatformCommandLineProviderTests.cs Outdated Show resolved Hide resolved
...itTests/Microsoft.Testing.Platform.UnitTests/CommandLine/PlatformCommandLineProviderTests.cs Outdated Show resolved Hide resolved
...soft.Testing.Platform.UnitTests/CommandLine/TreeNodeFilterCommandLineOptionsProviderTests.cs Outdated Show resolved Hide resolved
Evangelink
Evangelink reviewed May 13, 2024
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add assertion that the error message is empty/null when the option is valid?

...itTests/Microsoft.Testing.Platform.UnitTests/CommandLine/PlatformCommandLineProviderTests.cs Outdated Show resolved Hide resolved
...itTests/Microsoft.Testing.Platform.UnitTests/CommandLine/PlatformCommandLineProviderTests.cs Outdated Show resolved Hide resolved
...itTests/Microsoft.Testing.Platform.UnitTests/CommandLine/PlatformCommandLineProviderTests.cs Outdated Show resolved Hide resolved
@fhnaseer
removing mock,
8ba64bf 
splitting valid and invalid tests,
@Evangelink Evangelink merged commit e0e0be7 into main May 13, 2024
6 checks passed
@Evangelink Evangelink deleted the fhnaseer/commandline-validations branch May 13, 2024 12:10
fhnaseer added a commit that referenced this pull request May 13, 2024
@fhnaseer
Cleaning command line validations and adding unit tests (#2842)
c2ed6f3
Evangelink pushed a commit that referenced this pull request May 13, 2024
@fhnaseer
Cleaning command line validations and adding unit tests (#2842) (#2847)
03eb3e8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nohwnd nohwnd nohwnd left review comments

@Evangelink Evangelink Evangelink approved these changes

@MarcoRossignoli MarcoRossignoli Awaiting requested review from MarcoRossignoli MarcoRossignoli is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fhnaseer @nohwnd @Evangelink