-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed on build error xcopy on localized machines #847
Conversation
echo ( f | xcopy ) will not work, can get around with putting an '*' at the end, xcopy will treat then as file. This solutions builds fine on DE German machine.
So it is a fix for #507 and another version of #741. I don't know where we are now about this issue. I have a similar solution like you in my repo (mKay00@08e6039), but I deleted the |
well for me only src/cppwinrt.build.post.props line 29-30 and 36-37 were complaining and stoped for me building a working solution. The remaining usage of xcopy under certain cmd files in the tools directory works perfect. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, #741 hasn't been bumped in a bit, so I'm inclined to take this over the other.
I would like to see the echo f |
taken out of those commandlines though, if they're no longer needed.
set cmd switch to capital /Y from lower
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with this, but we'll need to close the other one then when this gets merged.
I think that the other files should be changed the same way to be consistent and to prevent possible future issues. |
Hello @DHowett-MSFT! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me and give me an instruction to get started! Learn more here. |
echo ( f | xcopy ) will not work, can get around with putting an '*' at the end, xcopy will treat then as file. This solutions builds
fine on DE German machine.
Summary of the Pull Request
References
PR Checklist
Detailed Description of the Pull Request / Additional comments