Add a context menu entry to "Open Windows Terminal here" #6100

zadjii-msft · 2020-05-21T17:39:05Z

Summary of the Pull Request

I went with the simple option - just open the Terminal with the default profile in the selected directory. I'd love to add another entry for "Open Terminal here with Profile...", but that's going to be follow-up work, once we sort out pulling the Terminal Settings into their own dll.

References

I'm going to need to file a bunch of follow-ups on this one.
- We should add another entry to let the user select which profile
- We should add the icon - I've got to do it in dllname.dll,1 format, which is annoying.
- These strings should be localized.
- Should this only appear on Shift+right click? Probably! However, I don't know how to do that.
A Win7 Explorer Command Sample which hasn't aged well
cppwinrt tutorial on using COM in cppwinrt
This is PowerToys' manifest and then their implementation which were both helpful
This was the sample I followed for how to actually set up the manifest, with the added magic that desktop5 lets you specify "Directory"

PR Checklist

Closes Add "open Windows terminal here" into right-click context menu #1060
I work here
Tests added/passed
[n/a] Requires documentation to be updated

Detailed Description of the Pull Request / Additional comments

This adds a COM class that implements IExplorerCommand, which is what lets us populate the context menu entry. We expose that type through a new DLL that is simply responsible for the shell extension, so that explorer doesn't need to load the entire Terminal just to populate that entry.

The COM class is tied to the application through some new entries in the manifest. The Clsid values are IMPORTANT - they must match the UUID of the implementation type. However, the Verb in the manifest didn't seem important.

I need the PlaceholderType so a winmd gets produced, otherwise the wapproj gets _very_ unhappy. I renamed things to make more sense. I actually launch the terminal, which is awesome.

WSLUser · 2020-05-21T18:19:58Z

If you're adding a COM interface then you may as well update the WPF control too. Nice screenshot! I wonder if there's a way to re-use "Open Here" for shells like Powershell, which already have their own. Maybe you could link to their context menu and use it to execute the profile?

DHowett · 2020-05-21T18:24:30Z

If you're adding a COM interface then you may as well update the WPF control too.

I fail to see why adding a COM interface to make a shell extension should touch the WPF control whatsoever. What updates does it even need?

src/cascadia/ShellExtension/OpenTerminalHere.cpp

DHowett · 2020-05-21T18:31:08Z

src/cascadia/ShellExtension/PlaceholderType.h

+namespace winrt::Microsoft::Terminal::ShellExtension::implementation
+{
+    struct PlaceholderType : PlaceholderTypeT<PlaceholderType>
+    {
+        PlaceholderType() = default;
+        GETSET_PROPERTY(int32_t, Placeholder, 42);
+    };
+}
+
+namespace winrt::Microsoft::Terminal::ShellExtension::factory_implementation
+{
+    BASIC_FACTORY(PlaceholderType);
+}


DHowett · 2020-05-21T18:31:23Z

src/cascadia/ShellExtension/PlaceholderType.idl

+// This class is just here to make our .wapproj play nicely with this project.
+// If we don't define any winrt types, then we won't generate a .winmd, and the
+// .wapproj will become _very_ mad at this project. So we'll use this
+// placeholder class just to trick cppwinrt into generating a winmd for us. If
+// we ever _do_ add a real winrt type to this project, this can be removed.


WHY DO WE LIVE IN THIS HELLSCAPE

src/cascadia/ShellExtension/ShellExtension.vcxproj

src/cascadia/ShellExtension/dllmain.cpp

WSLUser · 2020-05-21T18:56:08Z

I mean if someone builds the WPF control, they should also get this feature. Since this adds a COM interface, I would think it wouldn't be too much effort to add it there.

DHowett · 2020-05-21T18:57:13Z

The WPF control is a DLL that gets integrated into your existing project. It is by no means a standalone terminal application. There's no reason for that WPF CONTROL to add a shell extension.

…extension

src/cascadia/ShellExtension/OpenTerminalHere.h

DHowett · 2020-05-27T02:37:43Z

src/cascadia/ShellExtension/dllmain.cpp

-// https://github.com/microsoft/PowerToys/blob/master/
-//   src/modules/powerrename/dll/dllmain.cpp
+// We don't need to implement DllGetActivationFactory or DllCanUnloadNow
+// manually, since the generated module.g.cpp will handle it for us, and will


I'm surprised we get a module.g.cpp . . . did we make sure the cppwinrt WRL hookup works right?

Maybe we get it because of PlaceholderType? It does seem to do some WRL magic. I have no idea how, but it does seem to work ¯\_(ツ)_/¯

src/cascadia/ShellExtension/OpenTerminalHere.cpp

wigster · 2020-06-19T10:42:11Z

If the default Powershell $profile contains some sort of "cd path\to\folder", this overrides the path speification opened by WT through Explorer's Open WT here.

Maybe it is not recommened that $profile contain such a path specification, but I thought I'd flag this here.

zadjii-msft · 2020-06-19T11:27:10Z

If the default Powershell $profile contains some sort of "cd path\to\folder", this overrides the path speification opened by WT through Explorer's Open WT here.

Maybe it is not recommened that $profile contain such a path specification, but I thought I'd flag this here.

Yea there's not really a way for the Terminal to prevent such a command from running in your powershell profile. I'd definitely recommend against doing that if you want to use this context menu entry.

Stanzilla · 2020-06-29T22:14:21Z

No icon?

DHowett · 2020-06-29T22:15:05Z

#6246

Skyline404 · 2020-07-28T19:03:44Z

how i can disble this ?

DHowett · 2020-07-28T19:09:26Z

@Skyline404 discussion in #7008.

timonsku · 2020-08-07T14:55:47Z

Is there an ETA when the fix for not being able to launch it from an explorer window's "background", as was described in the release notes, will hit earlier Windows versions?

zadjii-msft · 2020-08-07T14:59:13Z

@PTS93 I'd recommend subscribing to #6414 - we're at the mercy of the platform release cycle currently. When we have an update to share, we'll update that thread.

tiagoboeing · 2020-08-24T00:48:43Z

Clicking on the folder and opening the context menu works!

I also suggest adding the option when anywhere on the folder was clicked. (When the folder is not selected)

DHowett · 2020-08-24T01:21:17Z

@tiagoboeing thanks! please read the comment directly above yours.

tiagoboeing · 2020-08-24T02:17:53Z

@DHowett yeap. Subscribed to the topic. Thanks!!

midnightelf · 2020-08-26T13:26:23Z

for those who have an access error, there is such a solution
in HKEY_CLASSES_ROOT\Directory\Background\shell\wt\command change default field value to wt.exe -d .

AnderssonPeter · 2021-01-11T15:46:01Z

I don't know if this is the right place to comment, but is there a task tracking

Show this when you click directly in a folder?
Allow the selection of what shell to open as a sub menu?

zadjii-msft · 2021-01-11T16:42:58Z

@AnderssonPeter I'd check the issues in this list to see if they match what you're looking for. That should have all the work we're tracking for this feature.

NetMage · 2021-01-19T18:59:05Z

When I open Windows Terminal, it opens a tab with TCC. When I press Ctrl+Shift+t, it opens with TCC. When I right-click Open in Windows Terminal, it opens Powershell - is there some different default profile that is being used here?

zadjii-msft · 2021-01-19T20:20:08Z

@NetMage I'm not sure I can really help you with that off the top of my head. I don't really know how TCC works - we might be able to help you investigate, but a 8 month old PR is probably not the place to have that discussion. Maybe try filing a new issue?

zadjii-msft added 10 commits May 20, 2020 15:22

Lets just start by adding a new project

c67b606

I guess this implements a COM interface?

d2aab9e

I'm not sure what I did wrong

f314d90

okay yea I missed this

f5fdae7

my dude it works

1d6b017

Well this works to pop up a cmd window

1851535

turns out it's real important to restart explorer.exe

44c7da6

Lots of polish

3c59824

I need the PlaceholderType so a winmd gets produced, otherwise the wapproj gets _very_ unhappy. I renamed things to make more sense. I actually launch the terminal, which is awesome.

Use a magic static to compute if this should be the dev build or not

643125f

cleanup for review

ad69e3f

ghost added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal. labels May 21, 2020

Good bot

ccb7160

DHowett requested changes May 21, 2020

View reviewed changes

ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label May 21, 2020

ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label May 21, 2020

This was referenced May 21, 2020

Add a explorer context menu entry to let the user pick the profile they want to "open here" #6111

Open

The strings in the explorer context menu entry need to be localized #6112

Closed

The explorer context menu should only appear on shift+click #6113

Open

zadjii-msft added 4 commits May 26, 2020 11:01

Merge remote-tracking branch 'origin/master' into dev/migrie/f/shell-…

b2184fb

…extension

do it with WRL, this is dirty but it works

bb2713c

Clean this code up a bit

ae42447

Clean up, add comments, remove audit mode

5b75378

DHowett approved these changes May 27, 2020

View reviewed changes

pr nits, spellcheck

753fcb3

This was referenced Jul 11, 2020

Publish MSIX/APPX on the GitHub Releases or anywhere else Microsoft Store ShareX/ShareX#4923

Closed

Add icon to "Open Windows Terminal here" Explorer context menu #6875

Closed

NonoHh mentioned this pull request Jul 16, 2020

No "Open Windows Terminal here" entry in context menu. #6945

Closed

revanmj mentioned this pull request Aug 25, 2020

[Feature request] context menu 0x7c13/Notepads#287

Open

GF-Huang mentioned this pull request Oct 21, 2020

🎉This issue was addressed in #6100, which has now been successfully released as Windows Terminal Preview v1.1.1671.0.:tada: #7990

Closed

This was referenced Oct 22, 2020

missing feature #8002

Closed

Open terminal from the right click context menu #8093

Closed

This was referenced Nov 13, 2020

Open Windows Terminal Here MicrosoftDocs/Console-Docs#176

Closed

"Open in Terminal" button in explorer right-click menu #8328

Closed

zadjii-msft mentioned this pull request Mar 26, 2021

"Open Windows Terminal Here" in the context menu is missing #9626

Closed

Alovchin91 mentioned this pull request Jul 6, 2021

Windows 11 context menu integration improvement git-for-windows/git#3307

Open

1 task

This comment has been minimized.

Sign in to view

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a context menu entry to "Open Windows Terminal here" #6100

Add a context menu entry to "Open Windows Terminal here" #6100

zadjii-msft commented May 21, 2020

WSLUser commented May 21, 2020

DHowett commented May 21, 2020

DHowett May 21, 2020

DHowett May 21, 2020

WSLUser commented May 21, 2020

DHowett commented May 21, 2020

DHowett May 27, 2020

zadjii-msft May 27, 2020

wigster commented Jun 19, 2020

zadjii-msft commented Jun 19, 2020

Stanzilla commented Jun 29, 2020

DHowett commented Jun 29, 2020

Skyline404 commented Jul 28, 2020

DHowett commented Jul 28, 2020

timonsku commented Aug 7, 2020

zadjii-msft commented Aug 7, 2020

tiagoboeing commented Aug 24, 2020

DHowett commented Aug 24, 2020

tiagoboeing commented Aug 24, 2020

midnightelf commented Aug 26, 2020

AnderssonPeter commented Jan 11, 2021

zadjii-msft commented Jan 11, 2021

NetMage commented Jan 19, 2021

zadjii-msft commented Jan 19, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Add a context menu entry to "Open Windows Terminal here" #6100

Add a context menu entry to "Open Windows Terminal here" #6100

Conversation

zadjii-msft commented May 21, 2020

Summary of the Pull Request

References

PR Checklist

Detailed Description of the Pull Request / Additional comments

WSLUser commented May 21, 2020

DHowett commented May 21, 2020

DHowett May 21, 2020

Choose a reason for hiding this comment

DHowett May 21, 2020

Choose a reason for hiding this comment

WSLUser commented May 21, 2020

DHowett commented May 21, 2020

DHowett May 27, 2020

Choose a reason for hiding this comment

zadjii-msft May 27, 2020

Choose a reason for hiding this comment

wigster commented Jun 19, 2020

zadjii-msft commented Jun 19, 2020

Stanzilla commented Jun 29, 2020

DHowett commented Jun 29, 2020

Skyline404 commented Jul 28, 2020

DHowett commented Jul 28, 2020

timonsku commented Aug 7, 2020

zadjii-msft commented Aug 7, 2020

tiagoboeing commented Aug 24, 2020

DHowett commented Aug 24, 2020

tiagoboeing commented Aug 24, 2020

midnightelf commented Aug 26, 2020

AnderssonPeter commented Jan 11, 2021

zadjii-msft commented Jan 11, 2021

NetMage commented Jan 19, 2021

zadjii-msft commented Jan 19, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.