Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a spec draft for Keybindings Arguments #1349

Merged
merged 6 commits into from Aug 16, 2019
Merged

Add a spec draft for Keybindings Arguments #1349

merged 6 commits into from Aug 16, 2019

Commits on Jun 20, 2019

  1. Add a spec draft for Keybindings Arguments. 

      Specs #1142.

  Just read the spec :)
    @zadjii-msft
    zadjii-msft committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    784528f View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2019

  1. Apply suggestions from code review 

    Co-Authored-By: Carlos Zamora <carlos.zamora@microsoft.com>
    @zadjii-msft @carlos-zamora
    zadjii-msft and carlos-zamora committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    4d5eb54 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2019

  1. Merge branch 'master' into dev/migrie/s/1142-keybindings-args

    @zadjii-msft
    zadjii-msft committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    47f6e25 View commit details
    Browse the repository at this point in the history

  2. Include notes on reliability, security, and Handleing Keybinding Args

    @zadjii-msft
    zadjii-msft committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    dd03ced View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2019

  1. Add some extra details from review 

      * Split up ActionArgs and ActionEventArgs
  * Clarify _not_ handling an action
  * Add some notes on parsing args
  * Add some future considerations on extensions
    @zadjii-msft
    zadjii-msft committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    56d042a View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2019

  1. Updating spec to remove the bulk of the IActionArgs and `IActionEve… 

    …ntArgs` implementations, as they're redundant.
    @zadjii-msft
    zadjii-msft committed Aug 14, 2019
    Configuration menu
    Copy the full SHA
    f326ce6 View commit details
    Browse the repository at this point in the history