Command palette and search box visual tweaks #12913
Conversation
|
Wow I friggin love it. I'm offline for the weekend already, but lemme ping the team on Monday. |
|
I, too, love this! Holy wow! |
|
I somewhat prefer the first design, as it is consistent with the search box and what VSCode does. Giving the controls some space affords us some visual distance between the shadow, tab content and search. How does the list look in tab switcher mode? (by default, Ctrl+Tab will trigger it; keep holding down Ctrl to see the switcher) |
zadjii-msft
added
the
Needs-Discussion
|
Ah, and how does this look in "commandline" mode? If you backspace the implicit |
|
|
|
This is gorgeous, I love it so much
For those playing along in HC mode |
|
I think this is waiting on the fix for the tab switcher top gap, right? I'm happy to review it still! I love it so much. |
|
I fixed the spacing, but there is still a crash happening sometimes when typing and deleting text inside the command palette. It can be easily replicated by typing >, backspace, >. |
I'll try debugging this more later today. Wild that it doesn't even like give a useful stack trace - it just explodes 🤔 |
zadjii-msft
added
Product-Terminal
Oh no. This won't be simple to diagnose. Lemme eye up the diff a bit closer, see if there's something that stands out. |
|
The issue happens when MinHeight in _filteredActionsView has values from 5 to 13. There's a connection to the negative padding, but I'm not sure why a key combination causes this. |
I suspect it has nothing to do with the key combo, but more about the showing/hiding/showing of certain UI elements. XAML can be finicky like that sometimes. At this point, we might just need to mess with the padding and general spacing to try and work around this. |
| <!-- Remove when implementing WinUI 2.6 --> | ||
| <Thickness x:Key="FlyoutContentPadding">12</Thickness> | ||
| <!-- Shadow that can be used by any control. --> | ||
| <ThemeShadow x:Name="SharedShadow" /> |
There was a problem hiding this comment.
this is so brilliant. This is what our life would be like if we had people who actually knew how to use XAML
| CornerRadius="{ThemeResource OverlayCornerRadius}" | ||
| Orientation="Horizontal" | ||
| Style="{ThemeResource SearchBoxBackground}"> | ||
| Shadow="{StaticResource SharedShadow}" |
There was a problem hiding this comment.
As a future note to self - if we ever do productize the WinUI Terminal control, we'll need to edit this, but that is DEFINITELY not a concern for now.
| @@ -482,6 +388,8 @@ | |||
|
|
|||
| <ListView x:Name="_filteredActionsView" | |||
| Grid.Row="2" | |||
| MinHeight="8" | |||
There was a problem hiding this comment.
I suppose here's a thought - why do we need this MinHeight at all? Setting it to 0 seems to mitigate the crash, and I don't know what it's needed for. At least, my eyes aren't sensitive enough to see what this changes...
ghost
added
the
Needs-Author-Feedback
|
|
ghost
removed
the
Needs-Author-Feedback
|
|
ghost
added
Area-User Interface
ghost
requested review from
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
carlos-zamora
moved this from To Cherry Pick
to Cherry Picked
in 1.13 Servicing Pipeline
Tweaked command palette and search box to better match the Windows 11 Fluent design: * Now styled like a normal flyout, with acrylic, shadow and border * TextBox now uses default style * Tweaked button and key chord designs * Adjusted spacing Fixes #12968.     (cherry picked from commit b63102f) Service-Card-Id: 81805346 Service-Version: 1.13
|
🎉 Handy links: |
ghost
mentioned this pull request
|
🎉 Handy links: |
Tweaked command palette and search box to better match the Windows 11 Fluent design:
Fixes #12968.