Search box visual tweaks

[ghost]

Made some changes to the search box:

• Adjusted spacing inside the box
• Detached the search box from the titlebar (as explained here)
• The search box is now 8px further to the left, in case the scrollbar is always enabled
• Made some controls use default properties, so that they'll adjust nicely to the 2.6 styles

Other: the search box and command palette now use OverlayCornerRadius

Before/After:

[zadjii-msft]

@cinnamon-msft for the design sign off, but I sure think it looks cool.

<showerthought> Plus, if it's detached, then we could add a little handle somewhere and allow the user to just like, drag it wherever they want in the Terminal. That would solve the whole "dock to top" vs "dock to bottom" debate! I'm absolutely not saying you should do this now though. That's just a crazy idea.</showerthought>

[DHowett]

I like it!

[cinnamon-msft]

I dig it. :) The only thing I'm not too keen on is that the close button is larger than the rest of the buttons. Is that just the default properties being applied?

[DHowett]

I suspect that that is "correct" -- the close button is not a search option!

[cinnamon-msft]

Right.. but I haven't found other search dialogs that have a larger close button compared to the other options :/

[ghost]

It was inspired by the InfoBar, which has a larger button that has the same space on top, right and bottom.

Would either of these look better?
A) consistent 8px menu padding

B) equal spacing around the close button

[cinnamon-msft]

I think I like option A better. 😄

[ghost]

I looked into getting some more default properties for the menu. Would that be ok for this PR?

[ghost]

The brushes can be done in a different PR, because it will take a bit longer. I wanted to use the default ones from menus, but in light mode it's hard to see which button is selected.

Is the design ok as it is now?

[zadjii-msft]

Checked this out locally - looks good to me, thanks!

[zadjii-msft]

<aside> It'd be cool if there was a shadow underneath the search dialog, like there is for the command palette. Almost certain there's an existing issue for this...

[zadjii-msft]

@msftbot make sure @cinnamon-msft signs off on this one

[DHowett]

I wonder how we got a merge conflict o_O

[zadjii-msft]

I wonder how we got a merge conflict o_O

It was the spellcheck PR 🤷 I think I merged it but I'm afraid that the GH conflict resolve tool secretly botched the xaml formatting. Guess we'll see...

[ghost]

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[ghost]

🎉Windows Terminal Preview v1.12.2922.0 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Store Download