Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On Build error xcopy on not english localized machines #507

Closed
DieselMeister opened this issue May 7, 2019 · 3 comments · Fixed by #847
Closed

On Build error xcopy on not english localized machines #507

DieselMeister opened this issue May 7, 2019 · 3 comments · Fixed by #847
Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation.
Milestone

Comments

@DieselMeister
Copy link

On a non english localized machine the xcopy command lines in the file:

cppwinrt.build.post.props

generate an error while building.

the "echo f" in front of the 4 commands (look for xcopy) works only if the word "file" in your language begins also with an "f".

In germany it's a "D" for "Datei".

@zadjii-msft
Copy link
Member

wait really

That seems insane to me, but that can be fixed. echo f | xcopy always seemed like a hack to me anyways.

@zadjii-msft zadjii-msft added this to the Windows Terminal v1.0 milestone May 7, 2019
@zadjii-msft zadjii-msft added the Issue-Bug It either shouldn't be doing this or needs an investigation. label May 7, 2019
@DHowett-MSFT
Copy link
Contributor

We should address this by removing manual xcopy steps :)

@schuettecarsten
Copy link

We should address this by removing manual xcopy steps :)

Or use robocopy, which should have the same command syntax for all languages.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants