Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Key binding for "New Window" #1051

Closed
quank123wip opened this issue May 29, 2019 · 21 comments · Fixed by #9208
Closed

Feature Request: Key binding for "New Window" #1051

quank123wip opened this issue May 29, 2019 · 21 comments · Fixed by #9208
Assignees
@zadjii-msft
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
Process Model Improvements
Milestone
Terminal v1.7

Comments

@quank123wip
Copy link

quank123wip commented May 29, 2019 •
edited

Summary of the new feature/enhancement

  • Default Hot key for call the Terminal such as Ctrl+Shift+T.

  • Custom Hot Key to call different Environments.

Technical implementation details

None yet.
@quank123wip quank123wip added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label May 29, 2019
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 29, 2019
@zadjii-msft
Copy link
Member

Do you possibly mean #653?

@zadjii-msft zadjii-msft added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label May 29, 2019
@quank123wip
Copy link
Author

Do you possibly mean #653?

No, just call a new window,just like konsole

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels May 29, 2019
@zadjii-msft
Copy link
Member

Oh, so just a keybinding for opening a new window? Yea we should do that.

@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels May 29, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 29, 2019
@zadjii-msft zadjii-msft added Needs-Tag-Fix Doesn't match tag requirements and removed Needs-Attention The core contributors need to come back around and look at this ASAP. labels May 29, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 29, 2019
@DHowett-MSFT DHowett-MSFT changed the title Feature Request: Hot key for call the terminal Feature Request: Key binding for "New Window" May 29, 2019
@DHowett-MSFT
Copy link
Contributor

I've renamed this to capture what I think it means.

@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label May 30, 2019
@DHowett-MSFT
Copy link
Contributor

Triaged. We need to think about what it means for terminal to have multiple windows. This will also impact how we do tab tearoff.

This was referenced Jun 14, 2019
Closed
Closed
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Jun 19, 2019
@ffes ffes mentioned this issue Aug 7, 2019
Closed
@DHowett-MSFT
Copy link
Contributor

When we do this, we should consider supporting shift-click on the + button to open a new window.

@quank123wip
Copy link
Author

When we do this, we should consider supporting shift-click on the + button to open a new window.

Maybe we should provide a setting?

@DHowett-MSFT
Copy link
Contributor

Why would that setting be turned off? What’s the alternative scenario?

@ffes
Copy link

ffes commented Aug 27, 2019

Note that in #2320 I suggested the Shift+Click on an entry in the list of profiles to open a new window as well.

@ffes
Copy link

ffes commented Aug 27, 2019

Maybe we should provide a setting?

To make a normal click on the button / entry in the list of profiles open a new window and shift-click open a new tab you mean? So swap the behavior.

That could very well become my personal preference 😉

@DHowett DHowett mentioned this issue Sep 25, 2020
Closed
@bschaepper
Copy link

Building on the solution of @zadjii-msft that @damnskippy referenced, heres how to open a new WSL window:
{ "command": { "action": "newTab", "commandline":"wt.exe new-tab -p <your profile name>" }, "keys": [ "ctrl+shift+n" ] }

@quank123wip
Copy link
Author

I think we need a better solution here. All workarounds are no use when the Windows Terminal isn't running, and for top-down(or drag-down) terminal, we also need a solution to start a new Windows Terminal instance. I think we'd better implement a guard process start when the system boot up. That should be in the Terminal v2.0 Milestone or any other Milestone before this feature.

@zadjii-msft
Copy link
Member

@quank123wip I think what' you're actually looking for is #653

@quank123wip
Copy link
Author

@quank123wip I think what' you're actually looking for is #653

Actually, I think both this feature and that need a same solution about auto start when system boots.

@zadjii-msft
Copy link
Member

@quangkieu Hey wadda ya know, that's already a setting we support. See startOnUserLogin

This was referenced Oct 27, 2020
Closed
Closed
@zadjii-msft zadjii-msft added this to To do in Process Model Improvements via automation Dec 7, 2020
@zadjii-msft zadjii-msft mentioned this issue Dec 7, 2020
Merged
7 tasks
@zadjii-msft zadjii-msft self-assigned this Dec 7, 2020
@nacitar
Copy link

nacitar commented Dec 22, 2020 •
edited

This is one of the few hotkeys missing for full compatibility with gnome-terminal's hotkeys.

Building on the solution of @zadjii-msft that @damnskippy referenced, heres how to open a new WSL window:
{ "command": { "action": "newTab", "commandline":"wt.exe new-tab -p <your profile name>" }, "keys": [ "ctrl+shift+n" ] }

This workaround also swaps the current window to the rightmost tab. =/

@zadjii-msft zadjii-msft moved this from To do to In progress in Process Model Improvements Feb 12, 2021
@zadjii-msft zadjii-msft mentioned this issue Feb 18, 2021
Merged
@ghost ghost added the In-PR This issue has a related PR label Feb 18, 2021
@zadjii-msft zadjii-msft moved this from In progress to In Review in Process Model Improvements Feb 18, 2021
@ghost ghost added In-PR This issue has a related PR and removed In-PR This issue has a related PR labels Feb 19, 2021
@ghost ghost closed this as completed in #9208 Feb 19, 2021
Process Model Improvements automation moved this from In Review to Done Feb 19, 2021
ghost pushed a commit that referenced this issue Feb 19, 2021
@zadjii-msft
Add support for the newWindow action (#9208)
049e37e 
Finally implements the `newWindow` action. It does so by
`ShellExecute`ing `wt.exe` with commandline args corresponding to the
ones that would create the same `NewTerminalArgs`. This works with #8898
and #9118 to allow new windows (even with `windowingBehavior:
useExisting`)

This is taken from my auto-elevate branch, hence the references to
elevation

References #5000
References projects/5
References #8898
References #9118
Closes #1051
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Feb 19, 2021
@ghost
Copy link

ghost commented Mar 1, 2021

🎉This issue was addressed in #9208, which has now been successfully released as Windows Terminal Preview v1.7.572.0.:tada:

Handy links:

@ForbiddenEra ForbiddenEra mentioned this issue Oct 12, 2022
Closed
@vkoukis vkoukis mentioned this issue Nov 6, 2022
Open
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
Process Model Improvements
  
Done
Milestone
Terminal v1.7
Development

Successfully merging a pull request may close this issue.

Add support for the newWindow action microsoft/terminal
9 participants
@nacitar @ffes @damnskippy @NeKJ @bschaepper @DHowett-MSFT @SlapBot @zadjii-msft @quank123wip