Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tab reordering #443

Closed
matthew4850 opened this issue May 6, 2019 · 10 comments · Fixed by #3478
Closed

Add support for tab reordering #443

matthew4850 opened this issue May 6, 2019 · 10 comments · Fixed by #3478
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone

Comments

@matthew4850
Copy link
Contributor

  • Your Windows build number: 10.0.18890.1000

  • What you're doing and what's happening: Attempting to drag tabs to reorder or detach does not work. Tabs stay exactly where they are and show no sign of moving

  • What's wrong / what should be happening instead: Tabs should be able to be reordered and detached.

@zadjii-msft
Copy link
Member

This is because we're using a really early version of the Tab Control. In future versions, it'll be more feature complete. Until then, all we request is patience :)

@zadjii-msft zadjii-msft added the Resolution-External For issues that are outside this codebase label May 7, 2019
@zadjii-msft zadjii-msft added this to the Windows Terminal v1.0 milestone May 7, 2019
@DHowett-MSFT DHowett-MSFT added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. and removed Resolution-External For issues that are outside this codebase labels May 9, 2019
@DHowett-MSFT
Copy link
Contributor

This one is actually on us. Tammy so kindly hooked up the reordering events for us!

@carlos-zamora even tried hooking them up to TerminalApp, but it underwent immediate and energetic disassembly.

@DHowett-MSFT DHowett-MSFT changed the title Tabs cannot be reorded Feature: Tab Reordering and tearoff May 9, 2019
@DHowett-MSFT DHowett-MSFT changed the title Feature: Tab Reordering and tearoff Feature: Tab reordering and tearoff May 9, 2019
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label May 17, 2019
@miniksa miniksa added Product-Terminal The new Windows Terminal. and removed Mass-Chaos labels May 17, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 18, 2019
@DHowett-MSFT DHowett-MSFT added this to Spec Needed in Specification Tracker May 28, 2019
@DHowett-MSFT
Copy link
Contributor

I'm repurposing this for tab reordering and demoting it to a Task. We'll track the (much larger) workitem to do tab tearoff as a deliverable for vBacklog.

Notes/reasoning:

  • Tab reordering is easy.
  • Tab tearoff requires us to answer the following questions:
    • WT.exe is a multi-instance app. How do we drag tabs between different processes?
    • We still need to design "new window" for tearoff-without-merge because we need a drop target for the old tab.

@DHowett-MSFT DHowett-MSFT changed the title Feature: Tab reordering and tearoff Add support for tab reordering Jun 14, 2019
@DHowett-MSFT DHowett-MSFT added Issue-Task It's a feature request, but it doesn't really need a major design. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Jun 14, 2019
@DHowett-MSFT DHowett-MSFT removed this from Spec Needed ❓ in Specification Tracker Jun 14, 2019
@DHowett-MSFT
Copy link
Contributor

Moved tearoff to #1256.

@JeroMiya
Copy link

JeroMiya commented Aug 7, 2019

Was about to open up my own issue but found this one - great idea! Just want to add one thing to the suggestion (not sure if it should be a separate issue, seems related?):

In addition to being able to tear off tabs into new windows, it would also be nice to be able to dock tabs onto an existing window, similar to Visual Studio, with support for snapping to quadrants to make it easy to setup a 4 x 4 tab window grid (in this use case, you'd snap left/right tabs first, then snap the last two into quadrants, if that makes sense). And also support other layouts like two tabs on the top half and one full width tab on the bottom (to do this, snap the top two left/right, then drag the bottom tab to the bottom middle line between them).

@mbrodala
Copy link

mbrodala commented Aug 7, 2019

@JeroMiya You should open a separate issue for your suggestion.

@eyalroth
Copy link

Another suggestion to add on top of this feature: add a keyboard shortcut for moving the currently active tab left/right. For instance, in my Chrome I have this configured to Alt+Shift+Left/Right arrow.

@ghost
Copy link

ghost commented Nov 26, 2019

🎉This issue was addressed in #3478, which has now been successfully released as Windows Terminal Preview v0.7.3291.0.:tada:

Handy links:

@LatinSuD
Copy link

Is there any key shortcut to move tab? Mouse dragging is not working too smooth.

@eyalroth
Copy link

@LatinSuD See #3593.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants