[rush] Relocate subspace parameter parsing to SelectionParameterSet #4689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
william2958
requested review from
iclanton,
octogonz,
apostolisms,
D4N14L and
dmichon-msft
as code owners
iclanton
changed the title
iclanton
reviewed
May 13, 2024
octogonz
reviewed
May 13, 2024
| [--from-version-policy VERSION_POLICY_NAME] [-v] [-c] | ||
| [--ignore-hooks] [-s] [-m] | ||
| [--from-version-policy VERSION_POLICY_NAME] | ||
| [--subspace SUBSPACE_NAME] [-v] [-c] [--ignore-hooks] [-s] |
There was a problem hiding this comment.
@william2958 Why does rush build specify a Rush subspace to be installed? That seems incorrect
|
Let's close this PR. I think it is superseded by #4700 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This MR addresses an issue where currently when the "--subspace" parameter is passed to the install or update action, i.e.
rush install --subspace my_subspace, all projects in the entire monorepo will be selected to be installed.Details
This issue was resolved by moving the "--subspace" cli parameter processing from BaseInstallAction to the SelectionParameterSet, so that the install and update actions are able to receive the correct projects for the filter parameters.
How it was tested
Impacted documentation