Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rushx-command-line] Add telemetry to rushx #4314

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nebosite
Copy link
Contributor

@nebosite nebosite commented Sep 6, 2023

Summary

Reuse the telemetry code in rush to record telemetry for rush x

Details

Changes:

  • Added telemetry initialization and logging to rushx
  • Refactored telemetry to take a hook instead of a rush session to prevent code creep from rush to rushx
  • Refactored telemetry to allow an undefined hook (rushx does not support this hook)
  • Refactored telemetry to take an executable name to distinquish telemetry output by file name. (This is a breaking change for downstream implementations that depend on the file name having a particular structure. This seems like a safer change than added an exeName property to the data because that can be missed and cause data processing errors by including the wrong files)

How it was tested

  • Invoked rushx build and rush update to verify that in both cases, the correct filename is written with correct data.
  • Invoked rushx not_exist and verified correct error data was logged in the telemetry output

Impacted documentation

@dmichon-msft
Copy link
Contributor

This PR is still marked as a draft, so assumed to not be ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants