Android app crashes when CodePush.getUpdateMetadata() is called

[calclavia]

Using React Native v0.33
Using React Native Code Push 1.13.5-beta

This crash happens whenever a new version is deployed to CodePush and the app finishes the update. The app seems to successfully update itself, but it crashes after the update. The app works as intended after relaunching.

The following Java crash error is consistently re-producible.

09-14 11:18:41.921 30450 30471 E AndroidRuntime: java.lang.IllegalStateException: Tried to use permissions API while not attached to an Activity.
09-14 11:18:41.921 30450 30471 E AndroidRuntime:        at com.facebook.react.modules.permissions.PermissionsModule.getPermissionAwareActivity(PermissionsModule.java:123)
09-14 11:18:41.921 30450 30471 E AndroidRuntime:        at com.facebook.react.modules.permissions.PermissionsModule.shouldShowRequestPermissionRationale(PermissionsModule.java:73)
09-14 11:18:41.921 30450 30471 E AndroidRuntime:        at java.lang.reflect.Method.invoke(Native Method)
09-14 11:18:41.921 30450 30471 E AndroidRuntime:        at com.facebook.react.bridge.BaseJavaModule$JavaMethod.invoke(BaseJavaModule.java:322)
09-14 11:18:41.921 30450 30471 E AndroidRuntime:        at com.facebook.react.cxxbridge.JavaModuleWrapper.invoke(JavaModuleWrapper.java:158)
09-14 11:18:41.921 30450 30471 E AndroidRuntime:        at com.facebook.react.bridge.queue.NativeRunnable.run(Native Method)
09-14 11:18:41.921 30450 30471 E AndroidRuntime:        at android.os.Handler.handleCallback(Handler.java:739)
09-14 11:18:41.921 30450 30471 E AndroidRuntime:        at android.os.Handler.dispatchMessage(Handler.java:95)
09-14 11:18:41.921 30450 30471 E AndroidRuntime:        at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:31)
09-14 11:18:41.921 30450 30471 E AndroidRuntime:        at android.os.Looper.loop(Looper.java:158)
09-14 11:18:41.921 30450 30471 E AndroidRuntime:        at com.facebook.react.bridge.queue.MessageQueueThreadImpl$3.run(MessageQueueThreadImpl.java:196)
09-14 11:18:41.921 30450 30471 E AndroidRuntime:        at java.lang.Thread.run(Thread.java:818)

[calclavia]

Actually, updated CodePush to v1.14 and it's fixed. :)

[richardhuaaa]

Thank you for filing this and posting the fix, much appreciated!

[jerson]

@calclavia i have the same problem but with v1.14 :/ please reopen

09-18 23:50:33.881   833  1033 D AudioService: Stream muted, skip playback
09-18 23:50:33.925 20648 20648 D AudioPlayerModule: onHostResume
09-18 23:50:33.959 20648 20648 D ReactNative: [CodePush] Loading JS bundle from "/data/user/0/com.app.music.staging/files/CodePush/56f364d115d2d57af414323a839517e2264cae4eebb2825658acab4a3cf8020e/CodePush/index.android.bundle"
09-18 23:50:34.015 20648 20648 D AudioPlayerModule: onHostPause
09-18 23:50:34.021 20648 20648 D AudioPlayerModule: onHostDestroy
09-18 23:50:34.034 20648 20648 W PhoneWindow: Previously focused view reported id 10 during save, but can't be found during restore.
09-18 23:50:34.034 20648 20648 D AudioPlayerModule: onHostResume
09-18 23:50:34.069 20648 20648 D ReactNative: [CodePush] Loading JS bundle from "/data/user/0/com.app.music.staging/files/CodePush/56f364d115d2d57af414323a839517e2264cae4eebb2825658acab4a3cf8020e/CodePush/index.android.bundle"
09-18 23:50:34.095 20648 20648 D AudioPlayerModule: onHostPause
09-18 23:50:34.119 20648 20648 D AudioPlayerModule: onHostDestroy
09-18 23:50:34.126 20648 20648 D AudioPlayerModule: onHostResume
09-18 23:50:34.154 20648 20648 D ReactNative: [CodePush] Loading JS bundle from "/data/user/0/com.app.music.staging/files/CodePush/56f364d115d2d57af414323a839517e2264cae4eebb2825658acab4a3cf8020e/CodePush/index.android.bundle"
09-18 23:50:34.173 20648 20648 D AudioPlayerModule: onHostPause
09-18 23:50:34.182 20648 20715 I ReactNativeJS: Running application "app" with appParams: {"initialProps":{},"rootTag":11}. __DEV__ === false, development-level warning are OFF, performance optimizations are ON
09-18 23:50:34.200 20648 20648 D AudioPlayerModule: onHostDestroy
09-18 23:50:34.210 20648 20648 D AudioPlayerModule: onHostResume
09-18 23:50:34.237 20648 20648 D ReactNative: [CodePush] Loading JS bundle from "/data/user/0/com.app.music.staging/files/CodePush/56f364d115d2d57af414323a839517e2264cae4eebb2825658acab4a3cf8020e/CodePush/index.android.bundle"
09-18 23:50:34.262 20648 20648 D AudioPlayerModule: onHostPause
09-18 23:50:34.282 20648 20648 D AudioPlayerModule: onHostDestroy
09-18 23:50:34.291 20648 20648 D AudioPlayerModule: onHostResume
09-18 23:50:34.323 20648 20648 D ReactNative: [CodePush] Loading JS bundle from "/data/user/0/com.app.music.staging/files/CodePush/56f364d115d2d57af414323a839517e2264cae4eebb2825658acab4a3cf8020e/CodePush/index.android.bundle"
09-18 23:50:34.344 20648 20648 D AudioPlayerModule: onHostPause
09-18 23:50:34.365 20648 20648 D AudioPlayerModule: onHostDestroy
09-18 23:50:34.375 20648 20648 D AudioPlayerModule: onHostResume
09-18 23:50:34.421 20648 20648 D ReactNative: [CodePush] Loading JS bundle from "/data/user/0/com.app.music.staging/files/CodePush/56f364d115d2d57af414323a839517e2264cae4eebb2825658acab4a3cf8020e/CodePush/index.android.bundle"
09-18 23:50:34.447 20648 20648 D AudioPlayerModule: onHostPause
09-18 23:50:34.478 20648 20648 D AudioPlayerModule: onHostDestroy
09-18 23:50:34.490 20648 20648 D AudioPlayerModule: onHostResume
09-18 23:50:34.490 20648 20674 I art     : Background sticky concurrent mark sweep GC freed 48647(3MB) AllocSpace objects, 45(900KB) LOS objects, 16% free, 17MB/20MB, paused 9.502ms total 112.667ms
09-18 23:50:34.519 20648 20648 D ReactNative: [CodePush] Loading JS bundle from "/data/user/0/com.app.music.staging/files/CodePush/56f364d115d2d57af414323a839517e2264cae4eebb2825658acab4a3cf8020e/CodePush/index.android.bundle"
09-18 23:50:34.539 20648 20648 D AudioPlayerModule: onHostPause
09-18 23:50:34.568 20648 20648 D AudioPlayerModule: onHostDestroy
09-18 23:50:34.574 20648 20715 I ReactNativeJS: Running application "app" with appParams: {"initialProps":{},"rootTag":21}. __DEV__ === false, development-level warning are OFF, performance optimizations are ON
09-18 23:50:34.583 20648 20648 D AudioPlayerModule: onHostResume
09-18 23:50:34.590 20648 20715 I ReactNativeJS: Running application "app" with appParams: {"initialProps":{},"rootTag":31}. __DEV__ === false, development-level warning are OFF, performance optimizations are ON
09-18 23:50:34.614 20648 20648 D ReactNative: [CodePush] Loading JS bundle from "/data/user/0/com.app.music.staging/files/CodePush/56f364d115d2d57af414323a839517e2264cae4eebb2825658acab4a3cf8020e/CodePush/index.android.bundle"
09-18 23:50:34.686 20648 20715 I ReactNativeJS: Running application "app" with appParams: {"initialProps":{},"rootTag":41}. __DEV__ === false, development-level warning are OFF, performance optimizations are ON
09-18 23:50:34.706 20648 20698 E AndroidRuntime: FATAL EXCEPTION: AsyncTask #5
09-18 23:50:34.706 20648 20698 E AndroidRuntime: Process: com.app.music.staging, PID: 20648
09-18 23:50:34.706 20648 20698 E AndroidRuntime: Theme: themes:{}
09-18 23:50:34.706 20648 20698 E AndroidRuntime: java.lang.RuntimeException: An error occurred while executing doInBackground()
09-18 23:50:34.706 20648 20698 E AndroidRuntime:    at android.os.AsyncTask$3.done(AsyncTask.java:309)
09-18 23:50:34.706 20648 20698 E AndroidRuntime:    at java.util.concurrent.FutureTask.finishCompletion(FutureTask.java:354)
09-18 23:50:34.706 20648 20698 E AndroidRuntime:    at java.util.concurrent.FutureTask.setException(FutureTask.java:223)
09-18 23:50:34.706 20648 20698 E AndroidRuntime:    at java.util.concurrent.FutureTask.run(FutureTask.java:242)
09-18 23:50:34.706 20648 20698 E AndroidRuntime:    at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:234)
09-18 23:50:34.706 20648 20698 E AndroidRuntime:    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1113)
09-18 23:50:34.706 20648 20698 E AndroidRuntime:    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:588)
09-18 23:50:34.706 20648 20698 E AndroidRuntime:    at java.lang.Thread.run(Thread.java:818)
09-18 23:50:34.706 20648 20698 E AndroidRuntime: Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'java.util.Iterator org.json.JSONObject.keys()' on a null object reference
09-18 23:50:34.706 20648 20698 E AndroidRuntime:    at com.microsoft.codepush.react.CodePushUtils.convertJsonObjectToWritable(CodePushUtils.java:65)
09-18 23:50:34.706 20648 20698 E AndroidRuntime:    at com.microsoft.codepush.react.CodePushNativeModule$4.doInBackground(CodePushNativeModule.java:307)
09-18 23:50:34.706 20648 20698 E AndroidRuntime:    at com.microsoft.codepush.react.CodePushNativeModule$4.doInBackground(CodePushNativeModule.java:283)
09-18 23:50:34.706 20648 20698 E AndroidRuntime:    at android.os.AsyncTask$2.call(AsyncTask.java:295)
09-18 23:50:34.706 20648 20698 E AndroidRuntime:    at java.util.concurrent.FutureTask.run(FutureTask.java:237)
09-18 23:50:34.706 20648 20698 E AndroidRuntime:    ... 4 more
09-18 23:50:34.718   833  1792 W ActivityManager:   Force finishing activity com.app.music.staging/com.app.music.MainActivity

[jerson]

@Silhouettes any progress? :/ :(

[alexHlebnikov]

Same problem here.

[richardhuaaa]

@jerson, sorry about the delay - I will try to get onto this today!

[richardhuaaa]

@jerson, @alexHlebnikov - to be clear, does this happen on RN 0.33?

[jerson]

@Silhouettes i tested in RN 0.33 , RN 0.34 RC and RN 0.34 :/

it seems that the problem is from RN 0.33

[alexHlebnikov]

I've got in RN 0.34.0.RC.0 and RN 0.34.0.

[cmcewen]

Getting the same crashes - from Crashlytics:

Fatal Exception: java.lang.RuntimeException: An error occurred while executing doInBackground()
       at android.os.AsyncTask$3.done(AsyncTask.java:309)
       at java.util.concurrent.FutureTask.finishCompletion(FutureTask.java:354)
       at java.util.concurrent.FutureTask.setException(FutureTask.java:223)
       at java.util.concurrent.FutureTask.run(FutureTask.java:242)
       at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:234)
       at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1113)
       at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:588)
       at java.lang.Thread.run(Thread.java:818)
Caused by java.lang.NullPointerException: Attempt to invoke virtual method 'java.util.Iterator org.json.JSONObject.keys()' on a null object reference
       at com.microsoft.codepush.react.CodePushUtils.convertJsonObjectToWritable(CodePushUtils.java:65)
       at com.microsoft.codepush.react.CodePushNativeModule$4.doInBackground(CodePushNativeModule.java:307)
       at com.microsoft.codepush.react.CodePushNativeModule$4.doInBackground(CodePushNativeModule.java:283)
       at android.os.AsyncTask$2.call(AsyncTask.java:295)
       at java.util.concurrent.FutureTask.run(FutureTask.java:237)
       at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:234)
       at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1113)
       at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:588)
       at java.lang.Thread.run(Thread.java:818)