App crashing on running updated bundle

[marcmo]

My app is using RNN and uses codepush. When running the app with react-native run-android everything works and I can update using codepush. But when I install the app, the app crashes after the codepush update.

Expected Behavior

same behavior on installed app and app running with local packager

Actual Behavior

What actually happens?

01-15 14:02:44.006 14439 14608 D ReactNative: [CodePush] Applying full update.
01-15 14:02:44.028 14439 14485 I ReactNativeJS: [CodePush] Installing update.
01-15 14:02:44.101 14439 14486 D ReactNative: [CodePush] Loading JS bundle from "/data/user/0/com.esrlabs.csm4/files/CodePush/48e46b6353890ca25110f096c80afa3356c8d8c8b70eaef1c2e70a99333de075/CodePush/index.android.bundle"
01-15 14:02:44.103 14439 14439 D ReactNative: ReactInstanceManager.recreateReactContextInBackgroundInner()
01-15 14:02:44.103 14439 14439 D ReactNative: ReactInstanceManager.recreateReactContextInBackgroundFromBundleLoader()
01-15 14:02:44.103 14439 14439 D ReactNative: ReactInstanceManager.recreateReactContextInBackground()

01-15 14:02:44.103 14439 14485 I ReactNativeJS: [CodePush] Restarting app
01-15 14:02:44.103 14439 14439 D ReactNative: ReactInstanceManager.runCreateReactContextOnNewThread()
01-15 14:02:44.103 14439 14439 D ReactNative: ReactInstanceManager.tearDownReactContext()
01-15 14:02:44.116 14439 14439 D ReactNative: CatalystInstanceImpl.destroy() start
01-15 14:02:44.118 14439 14613 D ReactNative: ReactInstanceManager.createReactContext()
01-15 14:02:44.135 14439 14613 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.airbnb.android.react.lottie.LottieAnimationViewManager
01-15 14:02:44.146 14439 14613 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.facebook.react.uimanager.LayoutShadowNode
...
01-15 14:02:44.205 14439 14439 D ReactNative: CatalystInstanceImpl.destroy() end
01-15 14:02:44.206 14439 14613 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.facebook.react.views.picker.ReactDialogPickerManager
...
01-15 14:02:44.269 14439 14613 D ReactNative: Initializing React Xplat Bridge.
01-15 14:02:44.271 14439 14613 D ReactNative: Initializing React Xplat Bridge before initializeBridge
01-15 14:02:44.279 14439 14613 D ReactNative: Initializing React Xplat Bridge after initializeBridge
01-15 14:02:44.279 14439 14613 D ReactNative: CatalystInstanceImpl.runJSBundle()
01-15 14:02:44.279 14439 14439 D ReactNative: ReactInstanceManager.setupReactContext()
01-15 14:02:44.280 14439 14439 D ReactNative: CatalystInstanceImpl.initialize()
01-15 14:02:44.281 14439 14439 D ReactNative: ReactInstanceManager.attachRootViewToInstance()
01-15 14:02:45.186 14439 14615 E ReactNativeJS: Module AppRegistry is not a registered callable module (calling runApplication)
01-15 14:02:45.210 14439 14616 E AndroidRuntime: FATAL EXCEPTION: mqt_native_modules
01-15 14:02:45.210 14439 14616 E AndroidRuntime: Process: com.esrlabs.csm4, PID: 14439
01-15 14:02:45.210 14439 14616 E AndroidRuntime: com.facebook.react.common.JavascriptException: Module AppRegistry is not a registered callable module (calling runApplication), stack:
01-15 14:02:45.210 14439 14616 E AndroidRuntime: 	at com.facebook.react.modules.core.ExceptionsManagerModule.showOrThrowError(ExceptionsManagerModule.java:56)
01-15 14:02:45.210 14439 14616 E AndroidRuntime: 	at com.facebook.react.modules.core.ExceptionsManagerModule.reportFatalException(ExceptionsManagerModule.java:40)
01-15 14:02:45.210 14439 14616 E AndroidRuntime: 	at java.lang.reflect.Method.invoke(Native Method)
01-15 14:02:45.210 14439 14616 E AndroidRuntime: 	at com.facebook.react.bridge.JavaMethodWrapper.invoke(JavaMethodWrapper.java:363)
01-15 14:02:45.210 14439 14616 E AndroidRuntime: 	at com.facebook.react.bridge.JavaModuleWrapper.invoke(JavaModuleWrapper.java:162)
01-15 14:02:45.210 14439 14616 E AndroidRuntime: 	at com.facebook.react.bridge.queue.NativeRunnable.run(Native Method)
01-15 14:02:45.210 14439 14616 E AndroidRuntime: 	at android.os.Handler.handleCallback(Handler.java:790)
01-15 14:02:45.210 14439 14616 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:99)
01-15 14:02:45.210 14439 14616 E AndroidRuntime: 	at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:31)
01-15 14:02:45.210 14439 14616 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:164)
01-15 14:02:45.210 14439 14616 E AndroidRuntime: 	at com.facebook.react.bridge.queue.MessageQueueThreadImpl$3.run(MessageQueueThreadImpl.java:194)
01-15 14:02:45.210 14439 14616 E AndroidRuntime: 	at java.lang.Thread.run(Thread.java:764)
01-15 14:02:45.545   766   778 I am_crash: [14439,0,com.esrlabs.csm4,950582854,com.facebook.react.common.JavascriptException,Module AppRegistry is not a registered callable module (calling runApplication), stack:
...

Environment

• react-native-code-push version: ^5.2.0-beta
• react-native version: 0.47.2
• react-native-navigation: 1.1.237
• iOS/Android/Windows version: android 8.1.0
• Does this reproduce on a debug build or release build? release
• Does this reproduce on a simulator, or only on a physical device? device

[marcmo]

what kind of clarifications can I provide?

[sergey-akhalkov]

Hi @marcmo, thanks for reaching us.

I've added clarification tag by mistake. As for your issue, could you please double check if your app has been configured correctly using this installation guide.

Please also take a look at this #790 (comment) - at the end of the comment you can find the configured app that should work.

[marcmo]

thanks for responding @sergey-akhalkov , I checked and my setup is almost exactly the same, only the name I use for my getJSBundleFile is different:

public class MainApplication extends NavigationApplication implements ReactInstanceHolder {

    @Override
    public boolean isDebug() {
        return BuildConfig.DEBUG;
    }

    @Nullable
    @Override
    public List<ReactPackage> createAdditionalReactPackages() {
        return getReactPackages();
    }

    @NonNull
    protected List<ReactPackage> getReactPackages() {
        return Arrays.<ReactPackage>asList(
                new CodePush(getResources().getString(R.string.reactNativeCodePush_androidDeploymentKey), getApplicationContext(), BuildConfig.DEBUG)
        );
    }

    @Override
    public void onCreate() {
        super.onCreate();
        SoLoader.init(this, /* native exopackage */ false);
    }

    @Override
    public String getJSBundleFile() {
        return CodePush.getJSBundleFile();
    }

    @Override
    public ReactInstanceManager getReactInstanceManager() {
        return getReactNativeHost().getReactInstanceManager();
    }
}

I had a lot of different issues and was able to resolve them but now what baffles me is that my setup works perfectly fine when running during development, but the error shows up in the installed release version.
(this error: Module AppRegistry is not a registered callable module (calling runApplication))

[sergey-akhalkov]

@marcmo, could you please share which way you are registering your callable module?
As for the sample app above, please pay attention to the following code:

import CodePush from 'react-native-code-push';

// register all screens of the app (including internal ones)
export function registerScreens() {
  Navigation.registerComponent('example.FirstTabScreen', () => CodePush(FirstTabScreen));
  ...
}

[marcmo]

are you sure about the call to CodePush? For me it seems CodePush is a function that takes an optional config as parameter and when called returns a function that takes the screen as parameter.

this is how I use codepush:

// module registration
export const CodePushConfig = {
  checkFrequency: CodePush.CheckFrequency.ON_APP_RESUME,
};

export const registerScreens = (store: Redux.Store<RootState>, provider) => {
  Navigation.registerComponent('xyz.IntroScreen', () => IntroScreen, store, provider);
  ...
  Navigation.registerComponent('xyz.DevOpts', () => CodePush(CodePushConfig)(DevOpts), store, provider);
  ...
};

// in DevOpts:
componentWillMount() {
  CodePush.sync({
  updateDialog: CodePush.DEFAULT_UPDATE_DIALOG,
  installMode: CodePush.InstallMode.IMMEDIATE,
  deploymentKey: Platform.select({
    android: '***',
    ios: '***',
    }),
  });
}

I have to admit I don't yet understand the RN app lifecycle implications on codepush. e.g. if it is possible/advisable to ask for a codepush sync like this:

AppState.addEventListener('change', handleAppStateChange);

const handleAppStateChange = (nextAppState: AppStateStatus) => {
  switch (nextAppState) {
    case 'active':
      CodePush.sync(AppConfig.codePushConfig);
      break;
    default:
  }
};

[sergey-akhalkov]

are you sure about the call to CodePush?

Yeah, I'm sure, please take a look at codePush(..) usage here.

this is how I use codepush:

Looks good, it's really weird why CodePush doesn't work for you. Could you please share the minimum working version of you App so I'll be able to take a look at it closer?
As of now I don't sure what exact root cause of your issue is, but I'm sure that demo app I've provided here #790 (comment) worked well for me - could you please also download it and confirm if it works for you?

[marcmo]

@sergey-akhalkov I will try to prepare a minimal app version but that will take me some time...
I was hoping you already experienced situations where code-push was working when running in development mode, but not in an release-build. That indicates to me that all my setup can actually work, my keys are correct and my configuration is OK.
but currently I'm really lost on this error:

Module AppRegistry is not a registered callable module (calling runApplication)

anyway...thanks for looking into this. I will try to setup a sharable example to demonstrate this behavior.

[sergey-akhalkov]

Hi @marcmo, got it, will wait for the demo!

I was hoping you already experienced situations where code-push was working when running in development mode, but not in an release-build.

Please note, that running RN app in the development mode is not actually the same as running in release mode, please see official docs:

NOTE: CodePush updates should be tested in modes other than Debug mode. In Debug mode, React Native app always downloads JS bundle generated by packager, so JS bundle downloaded by CodePush does not apply.

Loading JS bundle via packager is the main reason why you have no issue in debug mode. CodePush uses locally installed JS bundle instead.

[marcmo]

ok..I prepared a repository (android only) that can demonstrate this behavior:
https://github.com/marcmo/code-push-minimal
I would be grateful if you could take a look at this @sergey-akhalkov
the README has instructions on how to build and how to trigger codepush.
I guess you will have no problems with the codepush keys...keystore with everything that is needed is also in the repository.

[sergey-akhalkov]

@marcmo, great, thank you! I'm going to investigate it and let you know if I have any questions or If I'll found the root cause of the issue.