[949] - Remove argument internal in BaseRun::download_data. (#953)

* [949] - Remove argument internal in BaseRun::download_data. * Fix black. * Fix bug.
microsoft · Mar 8, 2022 · 57f7ed9 · 57f7ed9
1 parent 9e3d024
commit 57f7ed9
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 9 deletions.
diff --git a/scripts/data_collector/base.py b/scripts/data_collector/base.py
@@ -357,7 +357,6 @@ def download_data(
         delay=0,
         start=None,
         end=None,
-        interval="1d",
         check_data_length: int = None,
         limit_nums=None,
     ):
@@ -396,7 +395,7 @@ def download_data(
             delay=delay,
             start=start,
             end=end,
-            interval=interval,
+            interval=self.interval,
             check_data_length=check_data_length,
             limit_nums=limit_nums,
         ).collector_data()

diff --git a/scripts/data_collector/crypto/collector.py b/scripts/data_collector/crypto/collector.py
@@ -226,7 +226,6 @@ def download_data(
         delay=0,
         start=None,
         end=None,
-        interval="1d",
         check_data_length: int = None,
         limit_nums=None,
     ):
@@ -255,7 +254,7 @@ def download_data(
             $ python collector.py download_data --source_dir ~/.qlib/crypto_data/source/1d --start 2015-01-01 --end 2021-11-30 --delay 1 --interval 1d
         """
 
-        super(Run, self).download_data(max_collector_count, delay, start, end, interval, check_data_length, limit_nums)
+        super(Run, self).download_data(max_collector_count, delay, start, end, check_data_length, limit_nums)
 
     def normalize_data(self, date_field_name: str = "date", symbol_field_name: str = "symbol"):
         """normalize data

diff --git a/scripts/data_collector/fund/collector.py b/scripts/data_collector/fund/collector.py
@@ -253,7 +253,6 @@ def download_data(
         delay=0,
         start=None,
         end=None,
-        interval="1d",
         check_data_length: int = None,
         limit_nums=None,
     ):
@@ -282,7 +281,7 @@ def download_data(
             $ python collector.py download_data --source_dir ~/.qlib/fund_data/source/cn_data --region CN --start 2020-11-01 --end 2020-11-10 --delay 0.1 --interval 1d
         """
 
-        super(Run, self).download_data(max_collector_count, delay, start, end, interval, check_data_length, limit_nums)
+        super(Run, self).download_data(max_collector_count, delay, start, end, check_data_length, limit_nums)
 
     def normalize_data(self, date_field_name: str = "date", symbol_field_name: str = "symbol"):
         """normalize data

diff --git a/scripts/data_collector/yahoo/collector.py b/scripts/data_collector/yahoo/collector.py
@@ -900,9 +900,7 @@ def download_data(
             # get 1m data
             $ python collector.py download_data --source_dir ~/.qlib/stock_data/source --region CN --start 2020-11-01 --end 2020-11-10 --delay 0.1 --interval 1m
         """
-        super(Run, self).download_data(
-            max_collector_count, delay, start, end, self.interval, check_data_length, limit_nums
-        )
+        super(Run, self).download_data(max_collector_count, delay, start, end, check_data_length, limit_nums)
 
     def normalize_data(
         self,