Updating to Blockly v11 (pre-release) #10003
Draft
+2,098
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this as a draft because it relies on a pre-release version of Blockly.
This PR upgrades us to v11 of Blockly and in doing so restores the last of the features we lost with the great blockly swap. That includes:
The biggest chunk of code comes from re-implementing the block comments. The bubble code is mostly the same as Blockly's with the rendering re-implemented to resemble the workspace comment rendering. Unfortunately, the classes in Blockly make extensive use of the
privatekeyword so I had to copy the whole implementations just to swap the rendering.