Updates to the PresidioSentenceGenerator #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Map NATIONALITY entity to NRP not to LOCATION Change dict literals to dict constructors to improve readability
Asa higher level abstraction over PresidioDataGenerator for utilising all templates and providers in this library
…nguage for predictions
…fault AnalyzerEngine Validate chosen language is available in provided AnalyzerEngine
Map NATIONALITY entity to NRP not to LOCATION Change dict literals to dict constructors to improve readability
Asa higher level abstraction over PresidioDataGenerator for utilising all templates and providers in this library
…nguage for predictions
…fault AnalyzerEngine Validate chosen language is available in provided AnalyzerEngine
Update PresidioDataGenerator tests to make stronger assertions about contents of results
Update PresidioFakeRecordGenerator to use ReligionProvider
…-record-generator # Conflicts: # presidio_evaluator/data_generator/__init__.py # presidio_evaluator/data_generator/faker_extensions/providers.py # presidio_evaluator/data_generator/presidio_data_generator.py
Co-authored-by: melmatlis <93650751+melmatlis@users.noreply.github.com>
…lt providers and templates
…-record-generator
…ator # Conflicts: # presidio_evaluator/data_generator/presidio_data_generator.py
Rename PresidioFakeRecordGenerator to PresidioSentenceFaker to distinguish it from `RecordGenerator`
Move functions for loading data from FakeNameGenerator.com in faker format into new datasets.py module Move logic for choosing templates out of SentenceFaker into PresidioSentenceFaker Remove generic read file function Add missing HospitalProvider Update Recognizer tests to use PresidioSentenceProvider
Make single module to hold all sentence semantic dependency logic for Faker, including SentenceFaker, RecordGenerator and RecordsFaker
…aker Rename faker_to_presidio_entity_type to ENTITY_TYPE_MAPPING Make presidio_templates_file_path and presidio_additional_entity_providers available from package Update Data Generation README to outline choices
PresidioSentenceFaker
…cord-generator # Conflicts: # presidio_evaluator/data_generator/faker_extensions/sentences.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of the work on PR #50 by @Robbie-Palmer
FakerSpan,FakerSpanResultand updated code to useSpanandInputSamplerespectively instead, as discussed in PR PresidioSentenceFaker #50.SentenceFakerto inherit fromFakerinstead of using composition.SentenceFakerin the default option (RecordGeneratoris instantiated if records are passed, otherwise aSpanGeneratoris instantiated.)blackon all files I touched (which caused a lot of the changes in this PR)