Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Ubuntu 24.04 #30826

Merged
merged 2 commits into from
Jun 3, 2024
Merged

feat: support Ubuntu 24.04 #30826

merged 2 commits into from
Jun 3, 2024

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented May 15, 2024

This comment has been minimized.

@mxschmitt mxschmitt force-pushed the feature/support-ubuntu-24.04 branch 2 times, most recently from 4562e7e to 1d1be4b Compare May 15, 2024 21:42
@mxschmitt mxschmitt marked this pull request as ready for review May 15, 2024 21:43

This comment has been minimized.

This comment has been minimized.

@mxschmitt mxschmitt force-pushed the feature/support-ubuntu-24.04 branch 2 times, most recently from 0da438a to be95de6 Compare May 15, 2024 22:10
@mxschmitt mxschmitt added the CQ1 label May 15, 2024

This comment has been minimized.

docs/src/docker.md Outdated Show resolved Hide resolved
docs/src/intro-java.md Outdated Show resolved Hide resolved
docs/src/intro-js.md Outdated Show resolved Hide resolved
docs/src/intro-python.md Outdated Show resolved Hide resolved
@@ -450,6 +450,218 @@ export const deps: any = {
'libevent-2.1.so.7': 'libevent-2.1-7',
},
},

'ubuntu24.04-x64': {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does our deps generator script work or it's just a copy of 22?

This comment has been minimized.

This comment has been minimized.

@mxschmitt mxschmitt force-pushed the feature/support-ubuntu-24.04 branch from be95de6 to 0b6e1d8 Compare June 3, 2024 07:56
@mxschmitt mxschmitt added CQ1 and removed CQ1 labels Jun 3, 2024

This comment has been minimized.

This comment has been minimized.

@mxschmitt mxschmitt force-pushed the feature/support-ubuntu-24.04 branch from 0b6e1d8 to a82945b Compare June 3, 2024 10:15
@mxschmitt mxschmitt added CQ1 and removed CQ1 labels Jun 3, 2024
Copy link
Contributor

github-actions bot commented Jun 3, 2024

Test results for "tests 1"

1 failed
❌ [playwright-test] › playwright.ct-react.spec.ts:253:5 › should pass "key" attribute from JSX in variable

27438 passed, 612 skipped
✔️✔️✔️

Merge workflow run.

@mxschmitt mxschmitt merged commit 2c6fd72 into main Jun 3, 2024
90 of 106 checks passed
@mxschmitt mxschmitt deleted the feature/support-ubuntu-24.04 branch June 3, 2024 10:47
Copy link
Contributor

github-actions bot commented Jun 3, 2024

Test results for "tests 2"

5 fatal errors, not part of any test
54 failed
❌ [chromium-page] › page/page-drag.spec.ts:70:5 › Drag and drop › should work inside iframe
❌ [chromium-library] › library/browsercontext-events.spec.ts:43:5 › console event should work in popup 2
❌ [chromium-library] › library/chromium/css-coverage.spec.ts:128:3 › should work with a recently loaded stylesheet
❌ [chromium-library] › library/popup.spec.ts:129:3 › should use viewport size from window features
❌ [chromium-library] › library/popup.spec.ts:251:3 › should not throttle rAF in the opener page
❌ [chromium-library] › library/tracing.spec.ts:412:14 › should produce screencast frames fit
❌ [chromium-library] › library/tracing.spec.ts:412:14 › should produce screencast frames crop
❌ [chromium-library] › library/tracing.spec.ts:412:14 › should produce screencast frames scale
❌ [chromium-library] › library/tracing.spec.ts:742:5 › should flush console events on tracing stop
❌ [chromium-library] › library/video.spec.ts:803:3 › should saveAs video
❌ [chromium-page] › page/elementhandle-screenshot.spec.ts:199:5 › element screenshot › should wait for visible
❌ [chromium-page] › page/elementhandle-screenshot.spec.ts:231:5 › element screenshot › should wait for element to stop moving
❌ [chromium-page] › page/elementhandle-wait-for-element-state.spec.ts:23:3 › should wait for visible
❌ [chromium-page] › page/elementhandle-wait-for-element-state.spec.ts:56:3 › should wait for hidden
❌ [chromium-page] › page/elementhandle-wait-for-element-state.spec.ts:73:3 › should wait for hidden when detached
❌ [chromium-page] › page/elementhandle-wait-for-element-state.spec.ts:93:3 › should wait for aria enabled button
❌ [chromium-page] › page/elementhandle-wait-for-element-state.spec.ts:104:3 › should wait for button with an aria-disabled parent
❌ [chromium-page] › page/elementhandle-wait-for-element-state.spec.ts:115:3 › should wait for stable position
❌ [chromium-page] › page/elementhandle-wait-for-element-state.spec.ts:134:3 › should wait for editable input
❌ [chromium-page] › page/page-add-locator-handler.spec.ts:261:5 › should wait for hidden by default
❌ [chromium-page] › page/page-add-locator-handler.spec.ts:301:5 › should work with noWaitAfter
❌ [chromium-page] › page/page-click-timeout-4.spec.ts:20:3 › should timeout waiting for stable position
❌ [chromium-page] › page/page-click.spec.ts:183:3 › should waitFor display:none to be gone
❌ [chromium-page] › page/page-click.spec.ts:197:3 › should waitFor visibility:hidden to be gone
❌ [chromium-page] › page/page-click.spec.ts:211:3 › should waitFor visible when parent is hidden
❌ [chromium-page] › page/page-click.spec.ts:443:3 › should wait for stable position
❌ [chromium-page] › page/page-click.spec.ts:464:3 › should wait for becoming hit target
❌ [chromium-page] › page/page-click.spec.ts:496:3 › should wait for becoming hit target with trial run
❌ [chromium-page] › page/page-click.spec.ts:575:3 › should wait for button to be enabled
❌ [chromium-page] › page/page-click.spec.ts:587:3 › should wait for input to be enabled
❌ [chromium-page] › page/page-click.spec.ts:599:3 › should wait for select to be enabled
❌ [chromium-page] › page/page-click.spec.ts:625:3 › should wait for BUTTON to be clickable when it has pointer-events:none
❌ [chromium-page] › page/page-click.spec.ts:1061:3 › ensure events are dispatched in the individual tasks
❌ [chromium-page] › page/page-close.spec.ts:22:3 › should close page with active dialog
❌ [chromium-page] › page/page-dialog.spec.ts:67:3 › should be able to close context with open alert
❌ [chromium-page] › page/page-drag.spec.ts:346:3 › should report event.buttons
❌ [chromium-page] › page/page-evaluate.spec.ts:350:3 › should properly serialize PerformanceMeasure object
❌ [chromium-page] › page/page-event-console.spec.ts:94:3 › should format the message correctly with time/timeLog/timeEnd
❌ [chromium-page] › page/page-event-pageerror.spec.ts:69:3 › should contain the Error.name property
❌ [chromium-page] › page/page-event-pageerror.spec.ts:84:3 › should support an empty Error.name property
❌ [chromium-page] › page/page-event-pageerror.spec.ts:99:3 › should handle odd values
❌ [chromium-page] › page/page-event-pageerror.spec.ts:117:3 › should handle object
❌ [chromium-page] › page/page-event-pageerror.spec.ts:127:3 › should handle window
❌ [chromium-page] › page/page-expose-function.spec.ts:224:3 › should not result in unhandled rejection
❌ [chromium-page] › page/page-fill.spec.ts:254:3 › should retry on disabled element
❌ [chromium-page] › page/page-fill.spec.ts:269:3 › should retry on readonly element
❌ [chromium-page] › page/page-fill.spec.ts:284:3 › should retry on invisible element
❌ [chromium-page] › page/page-mouse.spec.ts:147:3 › should select the text with mouse
❌ [chromium-page] › page/page-screenshot.spec.ts:600:5 › page screenshot animations › should not capture infinite css animation
❌ [chromium-page] › page/page-select-option.spec.ts:236:3 › should wait for option to be present
❌ [chromium-page] › page/page-select-option.spec.ts:253:3 › should wait for option index to be present
❌ [chromium-page] › page/page-select-option.spec.ts:271:3 › should wait for multiple options to be present
❌ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:493:7 › cli codegen › should --save-trace
❌ [webkit-page] › page/page-drag.spec.ts💯5 › Drag and drop › should cancel on escape

62 flaky ⚠️ [chromium-page] › page/page-drag.spec.ts:272:5 › Drag and drop › should work if a frame is stalled
⚠️ [chromium-page] › page/page-drag.spec.ts:289:5 › Drag and drop › should work with the helper method
⚠️ [chromium-page] › page/page-drag.spec.ts:330:5 › Drag and drop › should work with locators
⚠️ [chromium-page] › page/page-mouse.spec.ts:221:3 › should tween mouse movement
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:668:7 › cli codegen › should assert navigation
⚠️ [chromium-page] › page/locator-misc-1.spec.ts:21:3 › should hover @smoke
⚠️ [chromium-page] › page/page-add-locator-handler.spec.ts:90:5 › should work with locator.hover()
⚠️ [chromium-page] › page/page-mouse.spec.ts:166:3 › should trigger hover state
⚠️ [chromium-page] › page/page-drag.spec.ts:246:5 › Drag and drop › should work if the drag event is captured but not canceled
⚠️ [chromium-page] › page/page-drag.spec.ts:272:5 › Drag and drop › should work if a frame is stalled
⚠️ [chromium-page] › page/page-drag.spec.ts:330:5 › Drag and drop › should work with locators
⚠️ [chromium-library] › library/capabilities.spec.ts:141:3 › should not crash on showDirectoryPicker
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:23:7 › cli codegen › should click
⚠️ [chromium-library] › library/trace-viewer.spec.ts:102:1 › should open simple trace viewer
⚠️ [chromium-page] › page/page-route.spec.ts:1005:5 › route.continue should throw if called twice
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:521:7 › cli codegen › should uncheck
⚠️ [firefox-page] › page/page-click.spec.ts:848:3 › should not hang when frame is detached
⚠️ [firefox-library] › library/video.spec.ts:189:5 › screencast › should capture static page
⚠️ [firefox-page] › page/page-event-request.spec.ts:171:3 › should return response body when Cross-Origin-Opener-Policy is set
⚠️ [firefox-library] › library/browsercontext-pages.spec.ts:128:3 › should not leak listeners during navigation of 20 pages
⚠️ [firefox-library] › library/browsercontext-pages.spec.ts:142:3 › should keep selection in multiple pages
⚠️ [firefox-library] › library/capabilities.spec.ts:121:3 › should support webgl 2 @smoke
⚠️ [firefox-library] › library/capabilities.spec.ts:193:3 › serviceWorker should intercept document request
⚠️ [firefox-library] › library/download.spec.ts:231:5 › download event › should error when saving with downloads disabled
⚠️ [firefox-library] › library/emulation-focus.spec.ts:179:12 › should focus with more than one page/context
⚠️ [firefox-library] › library/emulation-focus.spec.ts:190:12 › should not fire blur events when interacting with more than one page/context
⚠️ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:493:7 › cli codegen › should --save-trace
⚠️ [firefox-library] › library/tracing.spec.ts:292:5 › should overwrite existing file
⚠️ [firefox-page] › page/page-click-scroll.spec.ts:19:3 › should not hit scroll bar
⚠️ [firefox-page] › page/page-click.spec.ts:97:3 › should click the 1x1 div
⚠️ [firefox-page] › page/page-event-request.spec.ts:171:3 › should return response body when Cross-Origin-Opener-Policy is set
⚠️ [firefox-library] › library/tracing.spec.ts:412:14 › should produce screencast frames crop
⚠️ [firefox-page] › page/frame-goto.spec.ts:46:3 › should continue after client redirect
⚠️ [chromium-library] › library/inspector/cli-codegen-3.spec.ts:22:7 › cli codegen › should click locator.first
⚠️ [chromium-page] › page/page-add-locator-handler.spec.ts:90:5 › should work with locator.hover()
⚠️ [chromium-page] › page/page-mouse.spec.ts:166:3 › should trigger hover state
⚠️ [chromium-page] › page/page-mouse.spec.ts:186:3 › should trigger hover state on disabled button
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:23:7 › cli codegen › should click
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:309:7 › cli codegen › should fill textarea with new lines at the end
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:518:7 › cli codegen › should fill tricky characters
⚠️ [chromium-page] › page/page-mouse.spec.ts:221:3 › should tween mouse movement
⚠️ [webkit-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should work with --save-har
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:502:7 › cli codegen › should generate getByLabel without regex
⚠️ [webkit-page] › page/page-drag.spec.ts:34:5 › Drag and drop › should send the right events
⚠️ [webkit-page] › page/page-drag.spec.ts:70:5 › Drag and drop › should work inside iframe
⚠️ [webkit-page] › page/page-drag.spec.ts:260:5 › Drag and drop › should be able to drag the mouse in a frame
⚠️ [webkit-page] › page/page-drag.spec.ts:289:5 › Drag and drop › should work with the helper method
⚠️ [webkit-page] › page/page-drag.spec.ts:34:5 › Drag and drop › should send the right events
⚠️ [webkit-page] › page/page-drag.spec.ts:70:5 › Drag and drop › should work inside iframe
⚠️ [webkit-page] › page/page-drag.spec.ts:246:5 › Drag and drop › should work if the drag event is captured but not canceled
⚠️ [webkit-page] › page/page-drag.spec.ts:70:5 › Drag and drop › should work inside iframe
⚠️ [webkit-page] › page/page-drag.spec.ts💯5 › Drag and drop › should cancel on escape
⚠️ [webkit-page] › page/page-drag.spec.ts:272:5 › Drag and drop › should work if a frame is stalled
⚠️ [webkit-page] › page/page-drag.spec.ts:330:5 › Drag and drop › should work with locators
⚠️ [webkit-page] › page/page-drag.spec.ts:337:3 › should work if not doing a drag
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:341:7 › cli codegen › should press
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:668:7 › cli codegen › should assert navigation
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:562:7 › cli codegen › should assert value
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:634:7 › cli codegen › should assert visibility
⚠️ [webkit-library] › library/inspector/cli-codegen-python-async.spec.ts:115:5 › should print load/save storage_state
⚠️ [webkit-page] › page/page-drag.spec.ts💯5 › Drag and drop › should cancel on escape
⚠️ [webkit-page] › page/page-drag.spec.ts:246:5 › Drag and drop › should work if the drag event is captured but not canceled

195352 passed, 8544 skipped, 3227 did not run
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants