support no dependencies (#3319)

Fixes #3318 - check whether any dependencies exists before enumerating
them
Add Stacktrace output to high level functions
Download-BcNuGetPackageToFolder and Get-BcNuGetPackage

---------

Co-authored-by: freddydk <freddydk@users.noreply.github.com>

NuGet/Download-BcNuGetPackageToFolder.ps1

@@ -75,6 +75,7 @@ Function Download-BcNuGetPackageToFolder {
         [switch] $allowPrerelease
     )
 
+try {
     $returnValue = $false
     $findSelect = $select
     if ($select -eq 'LatestMatching') {
@@ -96,7 +97,13 @@ Function Download-BcNuGetPackageToFolder {
             $nuspec | ForEach-Object { Write-Verbose $_ }
             $manifest = [xml]$nuspec
             $dependenciesErr = ''
-            foreach($dependency in $manifest.package.metadata.dependencies.GetEnumerator()) {
+            if ($manifest.package.metadata.PSObject.Properties.Name -eq 'Dependencies') {
+                $dependencies = $manifest.package.metadata.Dependencies.GetEnumerator()
+            }
+            else {
+                $dependencies = @()
+            }
+            foreach($dependency in $dependencies) {
                 $dependencyVersion = $dependency.Version
                 $dependencyId = $dependency.Id
                 $dependencyCountry = ''
@@ -235,5 +242,10 @@ Function Download-BcNuGetPackageToFolder {
     }
     return $returnValue
 }
+catch {
+    Write-Host -ForegroundColor Red "Error Message: $($_.Exception.Message.Replace("`r",'').Replace("`n",' '))`r`nStackTrace: $($_.ScriptStackTrace)"
+    throw
+}
+}
 Set-Alias -Name Copy-BcNuGetPackageToFolder -Value Download-BcNuGetPackageToFolder
 Export-ModuleMember -Function Download-BcNuGetPackageToFolder -Alias Copy-BcNuGetPackageToFolder

NuGet/Get-BcNuGetPackage.ps1

@@ -53,6 +53,7 @@ Function Get-BcNuGetPackage {
         [switch] $allowPrerelease
     )
 
+try {    
     $feed, $packageId, $packageVersion = Find-BcNugetPackage -nuGetServerUrl $nuGetServerUrl -nuGetToken $nuGetToken -packageName $packageName -version $version -excludeVersions $excludeVersions -verbose:($VerbosePreference -eq 'Continue') -select $select -allowPrerelease:($allowPrerelease.IsPresent)
     if (-not $feed) {
         Write-Host "No package found matching package name $($packageName) Version $($version)"
@@ -63,4 +64,9 @@ Function Get-BcNuGetPackage {
         return $feed.DownloadPackage($packageId, $packageVersion)
     }
 }
+catch {
+    Write-Host -ForegroundColor Red "Error Message: $($_.Exception.Message.Replace("`r",'').Replace("`n",' '))`r`nStackTrace: $($_.ScriptStackTrace)"
+    throw
+}
+}
 Export-ModuleMember -Function Get-BcNuGetPackage

ReleaseNotes.txt

@@ -5,6 +5,8 @@ Issue 3301 Run-AlValidation fails running AppsourceCop "Could not load type 'Sys
 Give better error message if GitHub CLI, GIT or dotnet is not installed
 Issue 3301 Run-AlValidation fails running AppsourceCop "Could not load type 'System.Object' from assembly 'System.Private.CoreLib' (Regression in 6.0.4) 
 Issue 3313 Strange error in Copy-BcEnvironment
+Issue 3318 Download-BcNuGetPackageToFolder fails when no dependencies defined
+Add Stacktrace output to high level functions Download-BcNuGetPackageToFolder and Get-BcNuGetPackage
 
 6.0.4
 Rename AppInfoCache.json to cache_AppInfo.json (which by default is covered by .gitignore in AL-Go for GitHub)