Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Japanese translation to the GitHub Copilot workshop #130

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

SIkebe
Copy link
Member

@SIkebe SIkebe commented Apr 16, 2024

This PR introduces a Japanese translation for the GitHub Copilot workshop.

There’s one point that needs clarification: For the translated filename, should we use the language code such as ja, or the country code like jp?
The CONTRIBUTING.md states:

Add translations

You can localize any workshop in this repository by creating a new folder translations in the same directory as the original folder, and naming any translated file <original_name>.<country_code>.<extension>.
For example, the French translation of workshop.md would be translations/workshop.fr.md.

You can follow the same rule if you need to localize any asset, for example assets/image.png should be localized to assets/translations/image.fr.png.

However, I’ve noticed that various documents in this repository suggest using the language code. Could you please confirm which is correct?

@SIkebe
Copy link
Member Author

SIkebe commented Apr 18, 2024

FYI, I published GitHub Pages so that you can review the translated workshop page.
https://sikebe.github.io/moaw/workshop/github-copilot/translations/workshop.ja.md?step=0

@sinedied
Copy link
Collaborator

Thank you! Using language code here is fine.
If the original assets (images/code) were not updated, could you update the links to point to the original one instead of duplicating them inside the /translations/ subfolder?

@SIkebe
Copy link
Member Author

SIkebe commented Apr 24, 2024

Using language code here is fine.

Then, should I fix the CONTRIBUTING.md?

If the original assets (images/code) were not updated, could you update the links to point to the original one instead of duplicating them inside the /translations/ subfolder?

When I use relative links, the assets were not displayed and you can't download the assets zip file. So I copied those assets into the /translations/ subfolder.
http://localhost:4200/workshop/github-copilot/translations/workshop.ja.md?step=0

Which url should we use to show the assets on translated page locally and on GitHub Page?

image

image

@SIkebe
Copy link
Member Author

SIkebe commented May 8, 2024

Hi @sinedied
Do you have any opinions or advice regarding the above issue?

@sinedied
Copy link
Collaborator

Hi @SIkebe and thank you for your patience.
You're right it seems there's an issue when using ../assets, I'll open an issue and fix it as soon as possible.
Keep in mind it may take 1-2 weeks as it's a very busy period, again I thank you for your contribution and patience.

@SIkebe
Copy link
Member Author

SIkebe commented May 13, 2024

Thank you for confirming! Once the issue is resolved, I'll check that again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants