Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page with side-by-side controls for evaluating the effect of CornerRadius #765

Merged
merged 1 commit into from
Jun 4, 2019

Conversation

chrisglein
Copy link
Member

Adds a page to the test app for viewing CornerRadius across all* controls

image

*ish

@chrisglein chrisglein requested a review from a team as a code owner May 29, 2019 00:03
@mdtauk
Copy link
Contributor

mdtauk commented May 29, 2019

Could you perhaps also include a WebView with the FabricWeb versions of the controls alongside. If the templates are being updated, why not compare them.

These should also be tested alongside the CompactDensity metrics, which should be closer to the FabricWeb control sizing

image

image

image

image

https://developer.microsoft.com/en-us/fabric#/controls/web

@chrisglein
Copy link
Member Author

Could you perhaps also include a WebView with the FabricWeb versions of the controls alongside. If the templates are being updated, why not compare them.
These should also be tested alongside the CompactDensity metrics, which should be closer to the FabricWeb control sizing

Yes, @mdtauk I love this! I think it'd be great to be able to easily view side by side with WebView. I should point out that it's not a goal to exactly match (I tihnk there's more commentary about this on #524), but I still want to see the comparison.

I'm not going to tackle that as part of this PR... but let's totally do it. Want to open an issue (issues to improve the test app are totally okay) or just jam a PR of what that might look like?

@chrisglein chrisglein merged commit 441e4a4 into master Jun 4, 2019
@chrisglein chrisglein deleted the user/cglein/cornerRadiusPage branch June 4, 2019 23:49
@mdtauk
Copy link
Contributor

mdtauk commented Jun 4, 2019

Yes, @mdtauk I love this! I think it'd be great to be able to easily view side by side with WebView. I should point out that it's not a goal to exactly match (I tihnk there's more commentary about this on #524), but I still want to see the comparison.

I'm not going to tackle that as part of this PR... but let's totally do it. Want to open an issue (issues to improve the test app are totally okay) or just jam a PR of what that might look like?

Ideally you would have the compact density controls alongside also, either within the XAML columns, or in their own column - but that may be a better option to toggle at the page level.

As for the WebView, should this display a page stored online (matching the layout of the XAML columns), or would it include the Fabric Web javascript, css, and html pages within this app/sample?

@chrisglein
Copy link
Member Author

Ideally you would have the compact density controls alongside also, either within the XAML columns, or in their own column - but that may be a better option to toggle at the page level.

I actually originally created this side-by-side controls gallery to help me develop the new/compact density values. I'd actually love to work towards a way of getting this kind of index page without having to duplicate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants