Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hvsock service config annotation #2056

Merged
merged 1 commit into from Mar 18, 2024

Conversation

helsaawy
Copy link
Contributor

@helsaawy helsaawy commented Mar 6, 2024

Allow specifying the hyper-v configuration for specific service GUIDs via an annotation to allow dedicated hvsocket communication from the host to the guest

@helsaawy helsaawy marked this pull request as ready for review March 7, 2024 16:55
@helsaawy helsaawy requested a review from a team as a code owner March 7, 2024 16:55
Copy link
Contributor

@anmaxvl anmaxvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@katiewasnothere katiewasnothere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple questions but otherwise lgtm

Allow specifying the hyper-v configuration for specific service GUIDs
via an annotation to allow dedicated hvsocket communication from the
host to the guest

Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
@helsaawy helsaawy merged commit 6be41bc into microsoft:main Mar 18, 2024
19 checks passed
@helsaawy helsaawy deleted the hvsock-service-config branch March 18, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants