Polyfill react create ref #4182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: (28 commits) Scrollable pane sort stickies (microsoft#4111) Allow ScrollablePane to accept native properties. (microsoft#4095) Sticky (microsoft#4091) Applying package updates. [ColorRectangle, Sticky] Fixed null root refs (microsoft#4099) DatePicker: order of callbacks for onSelectDate and onAfterMenuDismiss (microsoft#4092) Applying package updates. Alhenry fix split button props (microsoft#4090) Fixing ComboBox styling by reverting button classname move (microsoft#4088) Update CODEOWNERS Undoing terrible change. [DetailsList] Fixed focus test (microsoft#4087) Added icons package screener test (microsoft#4082) ContextualMenu: Fix ContextualMenuUtility imports (microsoft#4085) [ContextualMenu] Made disabled buttons focusable (microsoft#4074) Convert Check to mergeStyles (microsoft#3880) [DetailsList] Add public focusIndex function (microsoft#3852) ComboBox button should have data-is-focusable="false" (microsoft#4070) Applying package updates. Focus Zone: Allow Tab to Skip Selection (microsoft#4061) ...
…c-react into polyfill-react-createRef * 'master' of https://github.com/OfficeDev/office-ui-fabric-react: ComboBox: Fixed input overlap rendering issue (microsoft#4102)
* master: (51 commits) Applying package updates. No unused variable (microsoft#4173) Use correct _list ref string (microsoft#4168) Nav: wire a link to expand/collapse behavior if it has no URL but has children (microsoft#4171) Addressing Issue microsoft#4147 - Nav Buttons have invalid `aria-describedby` value (microsoft#4159) Fix issue 3608: DetailsList horizontal scroll (microsoft#4164) Update package.json Image SCSS to MergeStyles Part 2: Style Conversion (microsoft#4151) Applying package updates. [SpinButton] Consistent styles to Button and TextField (microsoft#4098) ChoiceGroup: Flex layout for image and icon options (microsoft#4137) Initial set of Keytips work in experiments (microsoft#4062) Updating tsconfig in button bundle. BaseExtendedPicker: Create contextmenu for renderedItem, fix auto focus (microsoft#3954) Dropdown: Custom render options for multiselect - Bug fix microsoft#3571 (microsoft#3589) Fix documentcard theming (microsoft#4155) BasePicker: Fix not used onBlur callback of inputProps (microsoft#4000) (microsoft#4131) Allow Elements as Callout targets (microsoft#4134) CommandBar: Fixed null commandItemWidths (microsoft#4136) add check for when this.suggestionElement may be undefined (microsoft#4157) ...
Markionium
requested review from
johannao76,
micahgodbolt and
lorejoh12
as code owners
dzearing
reviewed
Mar 5, 2018
| @@ -42,7 +42,7 @@ export interface ITodoFormState { | |||
| * Button: https://fabricreact.azurewebsites.net/fabric-react/master/#/examples/button | |||
| */ | |||
| export default class TodoForm extends BaseComponent<ITodoFormProps, ITodoFormState> { | |||
| private _textField!: ITextField; | |||
| private _textField: RefObject<ITextField> = createRef<ITextField>(); | |||
There was a problem hiding this comment.
is it necessary to type this? Isn't it inferred by the assignment?
dzearing
reviewed
Mar 5, 2018
| "changes": [ | ||
| { | ||
| "comment": "", | ||
| "packageName": "@uifabric/experiments", |
There was a problem hiding this comment.
all change "none" can be deleted.
dzearing
reviewed
Mar 5, 2018
| @@ -43,8 +44,8 @@ export class BaseButton extends BaseComponent<IBaseButtonProps, IBaseButtonState | |||
| split: false, | |||
| }; | |||
|
|
|||
| private _buttonElement: HTMLElement; | |||
| private _splitButtonContainer: HTMLElement; | |||
| private _buttonElement = createRef<HTMLElement>(); | |||
There was a problem hiding this comment.
yes! see, there is no reason to type the refs. It should be implied.
There was a problem hiding this comment.
True, we should discuss this one though as it's related palantir/tslint#711 as i'm running into it when enabling typedef. (In the case of typedef it would require it ;))
dzearing
approved these changes
Mar 6, 2018
2 tasks
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
Mar 6, 2018
* master: Applying package updates. Polyfill react create ref (microsoft#4182) [Pickers] Add async debounce option to BasePicker (microsoft#4163) Facepile conditionally rendering aria-describedby (microsoft#4183) Applying package updates. Addressing Issue microsoft#4174 - 5.59.0 crashing in <ImageBase> (microsoft#4185) Website fix: Remove PureComponent (microsoft#4186) Add Keytip and KeytipLayer to experiments export (microsoft#4184)
chrismohr
pushed a commit
to chrismohr/office-ui-fabric-react
that referenced
this pull request
Apr 17, 2018
* Initial implementation of React.createRef polyfill * Updates based on feedback * Updates to components with refs * Fix Type * Fix lint * Revert to original Experiment * Fix typing * Add typedef to docs * Add change files * Remove empty change files
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Adds createRef polyfill to prepare for object refs and to have typed refs.
Focus areas to test
(optional)