Set focus to ContentDialogWithNonInteractiveContent on launch. #2931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
common/DevHomeAdaptiveCards/CardModels/DevHomeLaunchContentDialogButton.cs
Outdated
Show resolved
Hide resolved
vineeththomasalex
approved these changes
May 17, 2024
dhoehna
changed the title
krschau
approved these changes
May 20, 2024
common/DevHomeAdaptiveCards/CardModels/DevHomeLaunchContentDialogButton.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
The ContentDialogWithNonInteractiveContent is set up on the UI thread. This is causing a race-condition and the result is focus is not moved to the dialog.
I set the focus manually. Works with mouse and keyboard.
References and relevant issues
https://task.ms/50382877
Detailed description of the pull request / Additional comments
Validation steps performed
Went to Hyper-V page and launched the content dialogs with the keyboard.
PR checklist