-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Showing exceptions in the loading screen. #2927
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshilov7
reviewed
May 15, 2024
sshilov7
approved these changes
May 15, 2024
krschau
approved these changes
May 17, 2024
vineeththomasalex
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not merge this PR until 05/17
Summary of the pull request
Caught exceptions in the loading screen when running a task, and un-caught exceptions in a task did not crash DevHome. But also DevHome did not notify the user of the failed task.
This PR adds this feature. :) These are reported to the user in the Loading Screen and are treated as a failed task.
References and relevant issues
Detailed description of the pull request / Additional comments
The logic to figure what message to show based on internal information is tightly coupled resulting in some duplicate code.
This PR contains the first steps in de-coupling internal information and the loading screen message.
The logic to keep executing messages at the bottom of the list was fragile. I upgraded this to use two ListViews. One for finished messages, and one for executing messages. This resulted in
Validation steps performed
Used Random to cause a crash in the loading screen and the clone task exception.
Specified argument was out of the range of valid values (window)
is a crash in the code that runs a task.`Value cannot be null (parameter 'Blah') is an un-caught crash inside CloneRepoTask.
Please ignore the "Can't clone because the location is not empty" errors when retying. This is because the exception in CloneRepoTask is thrown after the repo cloned.
PR checklist
Movie!
https://github.com/microsoft/devhome/assets/2517139/14b9a23e-e4d1-43a0-8d2d-9502fc67d71a