Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed AppDetailsPage IsXXX to a collection of readonly checkboxes #2923

Merged
merged 2 commits into from
May 16, 2024

Conversation

andreww-msft
Copy link
Contributor

As part of this, created a new FrameworkTypes model, and AppRuntimeInfo now has an ObservableCollection of these. This should make it easier to add new framework types later (I added Python). In the UI, each item is represented by a readonly CheckBox in a WrapPanel, so that they flow when the window is sized. Standard CheckBox doesn't support readonly, so I added a custom ReadOnlyCheckBox control.

Also simplified the visibility of the problem fields in the AppDetailsPage - these are all now within a grid, so we only have to set visibility on the grid instead of on each field (should also improve perf very slightly).

Sorted the module list by name. Added a GridSplitter to the Modules page, so that the user can size the width of the list.

Also, when the user closes the Bar window, we save the expanded size to user settings (if not maximized).

Deleted some redundant fields and strings.

@dhoehna
Copy link
Contributor

dhoehna commented May 15, 2024

support readonly
Checkboxes have IsEnabled. That does make the control read-only. Did you need other behavior besides this?

Can you please put a video of the changes in the PR?

@andreww-msft
Copy link
Contributor Author

AppDetails-checkboxes

@andreww-msft andreww-msft merged commit 22d900d into main May 16, 2024
4 checks passed
@andreww-msft andreww-msft deleted the user/andreww/newfeature branch May 16, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants