Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V alihashish/actions #446

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

V alihashish/actions #446

wants to merge 4 commits into from

Conversation

AliHashish
Copy link

@AliHashish AliHashish commented Aug 21, 2023 •
edited

Executing a few customizable actions depending on some signals:

  • 2 default actions are provided, one with a light and dark mode theme (easily extensible to accomodate more default actions).
  • Custom actions can be inserted by the client (only concern is use of eval() function to execute client's code - possible security concern?)
  • Accepts extra parameters

@AliHashish
Live Signals Actions
4ca8b32
@AliHashish
Update upload.ts
0c749f2
@AliHashish
Live Signals Actions update
330d4c3 
- Parameters are now passed as a dictionary instead of an array of strings
- Client no longer has to make their function an arrow one, as this is handled automatically

This makes clarity-js more compatible with the other PR made for extra parameters.

This has been tested locally.
@AliHashish AliHashish changed the title V alihashish/live signals actions V alihashish/actions Aug 29, 2023
@AliHashish
Types and Thresholds
daa58df 
Handling different signal types, each with their own threshold
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@AliHashish