This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
1001: Fix scrolling and auto domain issue #1038
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
September 2, 2022 19:31
…d small size rendering in large data
zBritva
changed the title
MatthLee
reviewed
Mar 8, 2023
| } else { | ||
| dataBinding.domainMax = options.domainMax; | ||
| if (dataBinding.autoDomainMin) { | ||
| dataBinding.domainMin = scale.domainMin; |
There was a problem hiding this comment.
why are we using different variables for if we are scrolling or not? I have concerns about stale state if scrolling changes from on/off based on filtering.
There was a problem hiding this comment.
autoDomainMin alllows to sync min value of axis with value from new dataset, domainMin is the value itself.
There are correspond variables for max too.
There was a problem hiding this comment.
domainMax and domainMin define the range of values for the axis (For example values from 5 to 15). allowScrolling allows shifting the range up/down (to shift from 5-15 to 25-35)
MatthLee
reviewed
Mar 15, 2023
MatthLee
reviewed
Mar 15, 2023
MatthLee
approved these changes
Mar 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to fix issues reported in #1001, #1002