This repository has been archived by the owner on Jun 30, 2022. It is now read-only.
[TypeScript] Implement MultiLanguageLG in LocaleTemplateManager #3322
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2489
Purpose
What is the context of this pull request? Why is it being done?
Update
LocaleTemplateManager
to use MultiLanguageLG, while also fixing an issue when the locale has upper cases.Changes
Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)
Bot Solutions SDK
botbuilder-lg@4.8.0-preview
LocaleTemplateManager
with the implementation ofMultiLanguageLG
onTurn
of setLocaleMiddleware to seti18next
language to lower case.Sample Assistant and Sample Skill
copy-templates
script to also copy the.lg
files in the reponses folderbotbuilder-lg@4.8.0preview
dependency for testsindex
file to use the updatedLocaleTemplateManager
AllResponses.lg
files in both samples.lg
files to use$
instead of@
when using string templatesGenerator
copy-templates
script to also copy the.lg
files in the reponses folderTests
Is this covered by existing tests or new ones? If no, why not?
Yes, it's covered by all the existing tests in each solution
Documentation
Update the document related to the migration of a Bot (VA/Skill) to implement the GA changes
Feature Plan
Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.
-
Checklist
General