Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tabs in login - separate for system and non-system logins #25515

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

krritik
Copy link
Contributor

@krritik krritik commented Mar 18, 2024

Separate source logins into two tabs - system and non-system logins. Since non-system logins cannot be migrated.
Created separate tabs for both.
image
image

@krritik krritik marked this pull request as ready for review March 19, 2024 05:51
@coveralls
Copy link

coveralls commented Mar 19, 2024

Pull Request Test Coverage Report for Build 8339556546

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 41.757%

Totals Coverage Status
Change from base Build 8291620447: 0.001%
Covered Lines: 30827
Relevant Lines: 69082

💛 - Coveralls

Copy link
Contributor

@Ramudaykumar Ramudaykumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, hope you have tested functionality as per the requirements. Approving it with couple comments.

@abhims14
Copy link

Text for system login tab : "Excluded login/s"
Info box for Excluded login/s text: "Below login/s is/are excluded from login migration as they are either local service or system accounts at the source."

@krritik
Copy link
Contributor Author

krritik commented Mar 19, 2024

Looks good to me, hope you have tested functionality as per the requirements. Approving it with couple comments.

Yes @Ramudaykumar, I have verified it.

@krritik
Copy link
Contributor Author

krritik commented Mar 19, 2024

Text for system login tab : "Excluded login/s" Info box for Excluded login/s text: "Below login/s is/are excluded from login migration as they are either local service or system accounts at the source."

@abhims14, I did the following changes. Can you verify same in the screenshots attached above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants