New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tabs in login - separate for system and non-system logins #25515
base: main
Are you sure you want to change the base?
Conversation
extensions/sql-migration/src/wizard/loginMigrationTargetSelectionPage.ts
Show resolved
Hide resolved
Pull Request Test Coverage Report for Build 8339556546Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, hope you have tested functionality as per the requirements. Approving it with couple comments.
Text for system login tab : "Excluded login/s" |
Yes @Ramudaykumar, I have verified it. |
@abhims14, I did the following changes. Can you verify same in the screenshots attached above? |
Separate source logins into two tabs - system and non-system logins. Since non-system logins cannot be migrated.
Created separate tabs for both.