Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Port] Remove inline commands for dropping objects (#25399) #25400

Merged
merged 1 commit into from
Feb 24, 2024
Merged

[Port] Remove inline commands for dropping objects (#25399) #25400

merged 1 commit into from
Feb 24, 2024

Conversation

kisantia
Copy link
Contributor

Cherry-picking 9c4f37f from main to fix #25366

@kisantia kisantia linked an issue Feb 23, 2024 that may be closed by this pull request
Remove the drop database icon from the connection browser menu #25366
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8025110748

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 41.756%
Files with Coverage Reduction New Missed Lines %
src/sql/workbench/services/connection/browser/connectionDialogWidget.ts 1 73.44%
Totals Coverage Status
Change from base Build 8023606243: -0.001%
Covered Lines: 30826
Relevant Lines: 69082
💛 - Coveralls

@kisantia kisantia merged commit 7ddf171 into release/1.48 Feb 24, 2024
14 checks passed
@kisantia kisantia deleted the kisantia/port branch February 24, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corivera corivera corivera approved these changes

Assignees
No one assigned
Labels
Port Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the drop database icon from the connection browser menu
3 participants
@kisantia @coveralls @corivera