Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix arguments for openNotebookFolder command registration (#25374) #25385

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Fix arguments for openNotebookFolder command registration (#25374) #25385

merged 1 commit into from
Feb 22, 2024

Conversation

corivera
Copy link
Member

Porting change to release branch.

Closes #25369

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8009799882

Details

  • -1 of 2 (50.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 41.756%
Changes Missing Coverage Covered Lines Changed/Added Lines %
extensions/notebook/src/book/githubRemoteBook.ts 0 1 0.0%
Totals Coverage Status
Change from base Build 8009669233: 0.0%
Covered Lines: 30826
Relevant Lines: 69082
💛 - Coveralls

kisantia
kisantia approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@kisantia kisantia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge after the checks complete

@kisantia kisantia merged commit 893dc1c into release/1.48 Feb 22, 2024
14 checks passed
@kisantia kisantia deleted the corivera/portArgFix branch February 22, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kisantia kisantia kisantia approved these changes

Assignees
No one assigned
Labels
Port Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@corivera @coveralls @kisantia